Wrap call to scikit-learn's partial dependence method in a try/finally block #1232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1232 +/- ##
=======================================
Coverage 99.92% 99.92%
=======================================
Files 196 196
Lines 12193 12206 +13
=======================================
+ Hits 12184 12197 +13
Misses 9 9
Continue to review full report at Codecov.
|
angela97lin
requested review from
dsherry,
freddyaboulton,
bchen1116 and
jeremyliweishih
bchen1116
reviewed
Sep 28, 2020
| @@ -689,6 +689,20 @@ def test_partial_dependence_problem_types(problem_type, X_y_binary, X_y_multi, X | |||
| pipeline.feature_importances_ | |||
|
|
|||
|
|
|||
| @patch('evalml.model_understanding.graphs.sk_partial_dependence') | |||
| def test_partial_dependence_error_still_deletes_attributes(mock_part_dep, X_y_binary, logistic_regression_binary_pipeline_class): | |||
freddyaboulton
approved these changes
Sep 28, 2020
| # Delete scikit-learn attributes that were temporarily set | ||
| del pipeline._estimator_type | ||
| del pipeline.feature_importances_ | ||
| try: |
There was a problem hiding this comment.
If we have to repeat this pattern in the future, it'd be cool to use a context manager!
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From @dsherry's comment in #1150, wrap call to scikit-learn's partial dependence method in a try/finally block so that we still delete the set attributes even if call to scikit-learn's partial dependence method fails or errors out.