Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have lint run on __init__.py files #1234

Merged
merged 5 commits into from Sep 28, 2020
Merged

Have lint run on __init__.py files #1234

merged 5 commits into from Sep 28, 2020

Conversation

angela97lin
Copy link
Contributor

@angela97lin angela97lin commented Sep 28, 2020

Closes #737 by adding configuration to ignore F401 (module imported but unused) on __init__.py files.

@angela97lin angela97lin self-assigned this Sep 28, 2020
@codecov
Copy link

codecov bot commented Sep 28, 2020

Codecov Report

Merging #1234 into main will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1234   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files         196      196           
  Lines       12206    12206           
=======================================
  Hits        12197    12197           
  Misses          9        9           
Impacted Files Coverage Δ
evalml/automl/__init__.py 100.00% <ø> (ø)
evalml/automl/automl_algorithm/__init__.py 100.00% <ø> (ø)
evalml/automl/data_splitters/__init__.py 100.00% <ø> (ø)
evalml/data_checks/__init__.py 100.00% <ø> (ø)
evalml/demos/__init__.py 100.00% <ø> (ø)
evalml/model_family/__init__.py 100.00% <ø> (ø)
evalml/model_understanding/__init__.py 100.00% <ø> (ø)
..._understanding/prediction_explanations/__init__.py 100.00% <ø> (ø)
evalml/objectives/__init__.py 100.00% <ø> (ø)
evalml/pipelines/__init__.py 100.00% <ø> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52bbfea...5dcfea2. Read the comment docs.

@angela97lin angela97lin marked this pull request as ready for review Sep 28, 2020
Copy link
Contributor

@jeremyliweishih jeremyliweishih left a comment

very cool!

@angela97lin angela97lin merged commit 43ef057 into main Sep 28, 2020
@angela97lin angela97lin deleted the 737_init_linting branch Sep 28, 2020
@angela97lin angela97lin added this to the September 2020 milestone Sep 28, 2020
@angela97lin angela97lin mentioned this pull request Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Have lint run on __init__.py files
2 participants