Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused code from sphinx docs conf #1235

Merged
merged 3 commits into from Sep 28, 2020
Merged

Conversation

dsherry
Copy link
Collaborator

@dsherry dsherry commented Sep 28, 2020

Idk what this sed command was being used for, and it prints an error in every RTD build, so I'm gonna try deleting it and see what happens :)

@codecov
Copy link

codecov bot commented Sep 28, 2020

Codecov Report

Merging #1235 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1235   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files         196      196           
  Lines       12206    12206           
=======================================
  Hits        12197    12197           
  Misses          9        9           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20af560...2206798. Read the comment docs.

@dsherry dsherry marked this pull request as ready for review Sep 28, 2020
@dsherry dsherry requested review from angela97lin and gsheni Sep 28, 2020
@dsherry
Copy link
Collaborator Author

dsherry commented Sep 28, 2020

Successful RTD build. Docs.

Copy link
Contributor

@angela97lin angela97lin left a comment

LGTM! Thanks for this 👍

@dsherry dsherry merged commit 52bbfea into main Sep 28, 2020
@angela97lin angela97lin mentioned this pull request Sep 29, 2020
@freddyaboulton freddyaboulton deleted the ds_docs_conf_cleanup_sed branch May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants