-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix code in release notes #1243
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1243 +/- ##
=======================================
Coverage 99.93% 99.93%
=======================================
Files 207 207
Lines 12898 12898
=======================================
Hits 12889 12889
Misses 9 9 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for fixing this @angela97lin ! This looks great. The Stacked estimators don't look like code blocks right now in the docs you linked - I don't know if that's intended.
@freddyaboulton Ah I made that change pretty recently so the docs probably weren't updated / fully built. It's there now! 😁 (https://evalml.alteryx.com/en/ange_fix_release_notes/release_notes.html) |
Thank you @angela97lin ! Yep let's all try to remember to check the release notes for this before releasing and make sure they look good. I didn't do that. It is listed in the pre-release checklist. I bet we could write CI for this someday too. 👍 |
Fixing all code blocks / inserts in our release notes to work properly (currently only italicized).
Updated docs here: https://evalml.alteryx.com/en/ange_fix_release_notes/release_notes.html
Note: In the future, we should use `` to indicate code blocks, rather than ` which is for italics.