Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code in release notes #1243

Merged
merged 10 commits into from Sep 30, 2020
Merged

Fix code in release notes #1243

merged 10 commits into from Sep 30, 2020

Conversation

angela97lin
Copy link
Contributor

@angela97lin angela97lin commented Sep 29, 2020

Fixing all code blocks / inserts in our release notes to work properly (currently only italicized).

Updated docs here: https://evalml.alteryx.com/en/ange_fix_release_notes/release_notes.html

Note: In the future, we should use `` to indicate code blocks, rather than ` which is for italics.

@angela97lin angela97lin self-assigned this Sep 29, 2020
@codecov
Copy link

codecov bot commented Sep 29, 2020

Codecov Report

Merging #1243 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1243   +/-   ##
=======================================
  Coverage   99.93%   99.93%           
=======================================
  Files         207      207           
  Lines       12898    12898           
=======================================
  Hits        12889    12889           
  Misses          9        9           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d49db2...2d7a2fe. Read the comment docs.

@angela97lin angela97lin added this to the October 2020 milestone Sep 30, 2020
Copy link
Contributor

@bchen1116 bchen1116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good!

Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this @angela97lin ! This looks great. The Stacked estimators don't look like code blocks right now in the docs you linked - I don't know if that's intended.

@angela97lin
Copy link
Contributor Author

@freddyaboulton Ah I made that change pretty recently so the docs probably weren't updated / fully built. It's there now! 😁 (https://evalml.alteryx.com/en/ange_fix_release_notes/release_notes.html)

@angela97lin angela97lin merged commit d04dba7 into main Sep 30, 2020
@angela97lin angela97lin deleted the ange_fix_release_notes branch September 30, 2020 17:27
@dsherry
Copy link
Collaborator

dsherry commented Sep 30, 2020

Thank you @angela97lin ! Yep let's all try to remember to check the release notes for this before releasing and make sure they look good. I didn't do that. It is listed in the pre-release checklist. I bet we could write CI for this someday too. 👍

@dsherry dsherry mentioned this pull request Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants