-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update inheritance diagrams #1248
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1248 +/- ##
=======================================
Coverage 99.93% 99.93%
=======================================
Files 207 207
Lines 12898 12898
=======================================
Hits 12889 12889
Misses 9 9 Continue to review full report at Codecov.
|
inheritance_graph_attrs = dict(rankdir="LR", size='"1000, 333"', | ||
fontsize=30, labelfontsize=30, ratio='compress', dpi=960) | ||
inheritance_graph_attrs = dict(rankdir="TB", dpi=192.0, ranksep=0.02) | ||
inheritance_node_attrs = dict(fontsize=6, height=0.15, width=5, fixedsize=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't able to figure out how to left-align the text. label=r'\l'
created errors in rendering the docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries, this is still great :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bchen1116 thanks for wrestling with this! I think the new output is easier to look at and we should 🚢 :)
max-width: 620px; | ||
max-height: 50px; | ||
text-align: center; | ||
text-align: left; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird, so graphviz
isn't respecting this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dsherry Yea, when I look at the html and css styling of the rendered page, this graphviz
element is a larger container that contains the rendered image, so any text-aligning done here won't have an impact on the image contents.
@@ -18,3 +16,8 @@ | |||
{%- endfor %} | |||
{% endif %} | |||
{% endblock %} | |||
|
|||
Class Inheritance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it!
inheritance_graph_attrs = dict(rankdir="LR", size='"1000, 333"', | ||
fontsize=30, labelfontsize=30, ratio='compress', dpi=960) | ||
inheritance_graph_attrs = dict(rankdir="TB", dpi=192.0, ranksep=0.02) | ||
inheritance_node_attrs = dict(fontsize=6, height=0.15, width=5, fixedsize=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries, this is still great :)
fix #721
Docs here