Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update inheritance diagrams #1248

Merged
merged 7 commits into from Oct 1, 2020
Merged

update inheritance diagrams #1248

merged 7 commits into from Oct 1, 2020

Conversation

bchen1116
Copy link
Contributor

@bchen1116 bchen1116 commented Sep 30, 2020

fix #721

Docs here

@bchen1116 bchen1116 self-assigned this Sep 30, 2020
@codecov
Copy link

codecov bot commented Sep 30, 2020

Codecov Report

Merging #1248 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1248   +/-   ##
=======================================
  Coverage   99.93%   99.93%           
=======================================
  Files         207      207           
  Lines       12898    12898           
=======================================
  Hits        12889    12889           
  Misses          9        9           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d04dba7...c174188. Read the comment docs.

inheritance_graph_attrs = dict(rankdir="LR", size='"1000, 333"',
fontsize=30, labelfontsize=30, ratio='compress', dpi=960)
inheritance_graph_attrs = dict(rankdir="TB", dpi=192.0, ranksep=0.02)
inheritance_node_attrs = dict(fontsize=6, height=0.15, width=5, fixedsize=True)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't able to figure out how to left-align the text. label=r'\l' created errors in rendering the docs.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, this is still great :)

dsherry
dsherry approved these changes Oct 1, 2020
Copy link
Collaborator

@dsherry dsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bchen1116 thanks for wrestling with this! I think the new output is easier to look at and we should 🚢 :)

max-width: 620px;
max-height: 50px;
text-align: center;
text-align: left;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird, so graphviz isn't respecting this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dsherry Yea, when I look at the html and css styling of the rendered page, this graphviz element is a larger container that contains the rendered image, so any text-aligning done here won't have an impact on the image contents.

@@ -18,3 +16,8 @@
{%- endfor %}
{% endif %}
{% endblock %}

Class Inheritance
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!

inheritance_graph_attrs = dict(rankdir="LR", size='"1000, 333"',
fontsize=30, labelfontsize=30, ratio='compress', dpi=960)
inheritance_graph_attrs = dict(rankdir="TB", dpi=192.0, ranksep=0.02)
inheritance_node_attrs = dict(fontsize=6, height=0.15, width=5, fixedsize=True)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, this is still great :)

@bchen1116 bchen1116 merged commit 8cdfe14 into main Oct 1, 2020
@dsherry dsherry mentioned this pull request Oct 29, 2020
@freddyaboulton freddyaboulton deleted the bc_721_visual branch May 13, 2022 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API ref: Improve inheritance diagram visuals
2 participants