Allow user to filter which features to encode for OneHotEncoder#1249
Merged
angela97lin merged 7 commits intomainfrom Oct 2, 2020
Merged
Allow user to filter which features to encode for OneHotEncoder#1249angela97lin merged 7 commits intomainfrom
angela97lin merged 7 commits intomainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1249 +/- ##
=======================================
Coverage 99.93% 99.93%
=======================================
Files 207 207
Lines 12997 13031 +34
=======================================
+ Hits 12988 13022 +34
Misses 9 9
Continue to review full report at Codecov.
|
freddyaboulton
suggested changes
Oct 1, 2020
Contributor
freddyaboulton
left a comment
There was a problem hiding this comment.
@angela97lin I think this is great! Right now, we fit and transform on different columns which can cause bugs. I'm a fan of letting users fit/transform on the columns they pass in as features_to_encode to get around this but open to other solutions.
freddyaboulton
approved these changes
Oct 2, 2020
Contributor
freddyaboulton
left a comment
There was a problem hiding this comment.
@angela97lin Thanks this looks great!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1237.
I chose to raise a ValueError if any column in
features_to_encodedoes not exist in the input DataFrame.