Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up make_pipeline tests #1257

Merged
merged 10 commits into from Oct 5, 2020
Merged

Clean up make_pipeline tests #1257

merged 10 commits into from Oct 5, 2020

Conversation

angela97lin
Copy link
Contributor

Closes #1238 by cleaning up make_pipeline tests to test using all estimators.

@angela97lin angela97lin added this to the October 2020 milestone Oct 2, 2020
@angela97lin angela97lin self-assigned this Oct 2, 2020
@codecov
Copy link

codecov bot commented Oct 2, 2020

Codecov Report

Merging #1257 into main will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1257   +/-   ##
=======================================
  Coverage   99.93%   99.93%           
=======================================
  Files         207      207           
  Lines       13031    13055   +24     
=======================================
+ Hits        13022    13046   +24     
  Misses          9        9           
Impacted Files Coverage Δ
...estimators/classifiers/decision_tree_classifier.py 100.00% <100.00%> (ø)
evalml/tests/pipeline_tests/test_pipelines.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d72dff...810c269. Read the comment docs.

@angela97lin angela97lin marked this pull request as ready for review October 2, 2020 18:13
Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this @angela97lin ! Looks good to me!

@angela97lin angela97lin merged commit 4ae3207 into main Oct 5, 2020
@angela97lin angela97lin deleted the 1238_make_pipeline_cleanup branch October 5, 2020 15:29
@dsherry dsherry mentioned this pull request Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up make_pipeline and testing
2 participants