Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explain_predictions_best_worst custom index bug fix #1318

Merged
merged 2 commits into from Oct 20, 2020

Conversation

freddyaboulton
Copy link
Contributor

Pull Request Description

Fixes #1317


After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of docs/source/release_notes.rst to include this pull request by adding :pr:123.

@codecov
Copy link

codecov bot commented Oct 19, 2020

Codecov Report

Merging #1318 into main will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1318   +/-   ##
=======================================
  Coverage   99.94%   99.94%           
=======================================
  Files         213      213           
  Lines       13357    13357           
=======================================
  Hits        13349    13349           
  Misses          8        8           
Impacted Files Coverage Δ
...tanding/prediction_explanations/_user_interface.py 100.00% <100.00%> (ø)
...s/prediction_explanations_tests/test_explainers.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f8a964...7b94e7f. Read the comment docs.

@freddyaboulton freddyaboulton marked this pull request as ready for review October 19, 2020 16:25
(ProblemTypes.REGRESSION, "dict", regression_best_worst_answer_dict, no_best_worst_answer_dict, [0, 1]),
(ProblemTypes.REGRESSION, "text", regression_best_worst_answer, no_best_worst_answer, [4, 23]),
(ProblemTypes.REGRESSION, "dict", regression_best_worst_answer_dict, no_best_worst_answer_dict, [4, 10]),
(ProblemTypes.REGRESSION, "text", regression_best_worst_answer, no_best_worst_answer, ["foo", "bar"]),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow I had no idea indices could be set to anything that wasn't numbers. This is really cool!

Copy link
Contributor

@bchen1116 bchen1116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@eccabay eccabay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@freddyaboulton freddyaboulton force-pushed the fix-explain-predictions-custom-index branch from 34603e2 to 7b94e7f Compare October 20, 2020 14:47
@freddyaboulton freddyaboulton merged commit d254e31 into main Oct 20, 2020
2 checks passed
@freddyaboulton freddyaboulton deleted the fix-explain-predictions-custom-index branch October 20, 2020 15:02
@dsherry dsherry mentioned this pull request Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

explain_predictions_best_worst does not support custom index in the target
3 participants