explain_predictions_best_worst custom index bug fix #1318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1318 +/- ##
=======================================
Coverage 99.94% 99.94%
=======================================
Files 213 213
Lines 13357 13357
=======================================
Hits 13349 13349
Misses 8 8
Continue to review full report at Codecov.
|
freddyaboulton
requested review from
dsherry,
angela97lin,
bchen1116,
jeremyliweishih,
eccabay and
christopherbunn
and removed request for
dsherry
bchen1116
reviewed
Oct 19, 2020
| (ProblemTypes.REGRESSION, "dict", regression_best_worst_answer_dict, no_best_worst_answer_dict, [0, 1]), | ||
| (ProblemTypes.REGRESSION, "text", regression_best_worst_answer, no_best_worst_answer, [4, 23]), | ||
| (ProblemTypes.REGRESSION, "dict", regression_best_worst_answer_dict, no_best_worst_answer_dict, [4, 10]), | ||
| (ProblemTypes.REGRESSION, "text", regression_best_worst_answer, no_best_worst_answer, ["foo", "bar"]), |
There was a problem hiding this comment.
Wow I had no idea indices could be set to anything that wasn't numbers. This is really cool!
freddyaboulton
force-pushed
the
fix-explain-predictions-custom-index
branch
from
34603e2
to
7b94e7f
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fixes #1317
After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of
docs/source/release_notes.rstto include this pull request by adding :pr:123.