Rename LabelLeakageDataCheck to TargetLeakageDataCheck. - #1319
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1319 +/- ##
=======================================
Coverage 99.94% 99.94%
=======================================
Files 213 213
Lines 13357 13357
=======================================
Hits 13349 13349
Misses 8 8
Continue to review full report at Codecov.
|
freddyaboulton
marked this pull request as ready for review
October 19, 2020 19:21
freddyaboulton
requested review from
angela97lin,
bchen1116,
christopherbunn,
dsherry,
eccabay and
jeremyliweishih
October 19, 2020 19:21
bchen1116
approved these changes
Oct 19, 2020
| from evalml.data_checks.target_leakage_data_check import TargetLeakageDataCheck | ||
|
|
||
|
|
||
| def test_label_leakage_data_check_init(): |
Contributor
There was a problem hiding this comment.
Not pressing but maybe change name to test_target_leakage_data_check_init and etc for the test names?
freddyaboulton
force-pushed
the
1303-rename-labelleakage-targetleakage
branch
from
October 20, 2020 13:39
c78fbfc to
f125e37
Compare
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fix #1303
After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of
docs/source/release_notes.rstto include this pull request by adding :pr:123.