Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename LabelLeakageDataCheck to TargetLeakageDataCheck. #1319

Merged
merged 4 commits into from Oct 20, 2020

Conversation

freddyaboulton
Copy link
Contributor

Pull Request Description

Fix #1303


After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of docs/source/release_notes.rst to include this pull request by adding :pr:123.

@codecov
Copy link

codecov bot commented Oct 19, 2020

Codecov Report

Merging #1319 into main will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1319   +/-   ##
=======================================
  Coverage   99.94%   99.94%           
=======================================
  Files         213      213           
  Lines       13357    13357           
=======================================
  Hits        13349    13349           
  Misses          8        8           
Impacted Files Coverage Δ
evalml/data_checks/__init__.py 100.00% <100.00%> (ø)
evalml/data_checks/default_data_checks.py 100.00% <100.00%> (ø)
evalml/data_checks/target_leakage_data_check.py 100.00% <100.00%> (ø)
evalml/tests/data_checks_tests/test_data_checks.py 100.00% <100.00%> (ø)
...ata_checks_tests/test_target_leakage_data_check.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dec69b1...f125e37. Read the comment docs.

Copy link
Contributor

@angela97lin angela97lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Copy link
Contributor

@bchen1116 bchen1116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

from evalml.data_checks.target_leakage_data_check import TargetLeakageDataCheck


def test_label_leakage_data_check_init():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not pressing but maybe change name to test_target_leakage_data_check_init and etc for the test names?

Copy link
Contributor

@eccabay eccabay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@freddyaboulton freddyaboulton force-pushed the 1303-rename-labelleakage-targetleakage branch from c78fbfc to f125e37 Compare October 20, 2020 13:39
@freddyaboulton freddyaboulton merged commit 1f8a964 into main Oct 20, 2020
2 checks passed
@freddyaboulton freddyaboulton deleted the 1303-rename-labelleakage-targetleakage branch October 20, 2020 14:44
Copy link
Collaborator

@dsherry dsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good

@dsherry dsherry mentioned this pull request Oct 29, 2020
@dsherry dsherry mentioned this pull request Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename "Label Leakage" data check to "Target Leakage"
5 participants