Minor Documentation Changes for the API #1323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1323 +/- ##
=======================================
Coverage 99.94% 99.94%
=======================================
Files 213 213
Lines 13387 13387
=======================================
Hits 13379 13379
Misses 8 8
Continue to review full report at Codecov.
|
bchen1116
commented
Oct 20, 2020
| @@ -238,13 +238,14 @@ def _validate_objective(self, objective): | |||
| if isinstance(objective, type): | |||
| if objective in non_core_objectives: | |||
| raise ValueError(f"{objective.name.lower()} is not allowed in AutoML! " | |||
| "Use evalml.objectives.utils.get_core_objective_names()" | |||
| "Use evalml.objectives.utils.get_core_objective_names() " | |||
There was a problem hiding this comment.
Fixed the spacing in this message
bchen1116
commented
Oct 20, 2020
| @@ -73,11 +73,10 @@ def split_data(X, y, regression=False, test_size=.2, random_state=None): | |||
|
|
|||
|
|
|||
| def number_of_features(dtypes): | |||
| """Get the number of features for specific dtypes. | |||
| """Get the number of features of each specific dtype in a DataFrame. | |||
There was a problem hiding this comment.
Wanted to clear up this description so users know that it takes in pd.DataFrame().dtypes
bchen1116
requested review from
dsherry,
freddyaboulton,
angela97lin,
christopherbunn,
eccabay and
jeremyliweishih
and removed request for
dsherry and
freddyaboulton
freddyaboulton
approved these changes
Oct 21, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make minor documentation changes based on issues I found during the blitz
Reordered preprocessing API calls here
AutoMLSearch data_check_results docs here
number_of_features docs here