-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor Documentation Changes for the API #1323
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1323 +/- ##
=======================================
Coverage 99.94% 99.94%
=======================================
Files 213 213
Lines 13387 13387
=======================================
Hits 13379 13379
Misses 8 8
Continue to review full report at Codecov.
|
@@ -238,13 +238,14 @@ def _validate_objective(self, objective): | |||
if isinstance(objective, type): | |||
if objective in non_core_objectives: | |||
raise ValueError(f"{objective.name.lower()} is not allowed in AutoML! " | |||
"Use evalml.objectives.utils.get_core_objective_names()" | |||
"Use evalml.objectives.utils.get_core_objective_names() " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed the spacing in this message
@@ -73,11 +73,10 @@ def split_data(X, y, regression=False, test_size=.2, random_state=None): | |||
|
|||
|
|||
def number_of_features(dtypes): | |||
"""Get the number of features for specific dtypes. | |||
"""Get the number of features of each specific dtype in a DataFrame. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wanted to clear up this description so users know that it takes in pd.DataFrame().dtypes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bchen1116 !
Make minor documentation changes based on issues I found during the blitz
Reordered preprocessing API calls here
AutoMLSearch data_check_results docs here
number_of_features docs here