Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Graphviz to Requirements.txt #1327

Merged
merged 8 commits into from Oct 22, 2020
Merged

Move Graphviz to Requirements.txt #1327

merged 8 commits into from Oct 22, 2020

Conversation

bchen1116
Copy link
Contributor

fix #1311

@bchen1116 bchen1116 self-assigned this Oct 21, 2020
@codecov
Copy link

codecov bot commented Oct 21, 2020 •
edited

Codecov Report

Merging #1327 into main will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1327      +/-   ##
==========================================
+ Coverage   99.95%   99.95%   +0.01%     
==========================================
  Files         213      213              
  Lines       13555    13560       +5     
==========================================
+ Hits        13548    13553       +5     
  Misses          7        7
Impacted Files Coverage Δ
evalml/tests/pipeline_tests/test_graphs.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc9d185...631518d. Read the comment docs.

freddyaboulton
freddyaboulton approved these changes Oct 21, 2020
View reviewed changes
Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bchen1116 !

evalml/tests/pipeline_tests/test_graphs.py Outdated Show resolved Hide resolved
dsherry
dsherry approved these changes Oct 22, 2020
View reviewed changes
Copy link
Contributor

@dsherry dsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @bchen1116 ! Hey @rpeck we've fixed that graphviz bug you mentioned :)

evalml/tests/pipeline_tests/test_graphs.py Show resolved Hide resolved
evalml/tests/pipeline_tests/test_graphs.py Show resolved Hide resolved
requirements.txt Show resolved Hide resolved
@bchen1116 bchen1116 merged commit 4250054 into main Oct 22, 2020
@dsherry dsherry mentioned this pull request Oct 29, 2020
Merged
@freddyaboulton freddyaboulton deleted the bc_1311_graphviz branch May 13, 2022 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherry dsherry dsherry approved these changes

@freddyaboulton freddyaboulton Awaiting requested review from freddyaboulton

@jeremyliweishih jeremyliweishih Awaiting requested review from jeremyliweishih

@christopherbunn christopherbunn Awaiting requested review from christopherbunn

@eccabay eccabay Awaiting requested review from eccabay

Assignees

@bchen1116 bchen1116

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Graphviz required to run graph code
3 participants
@bchen1116 @dsherry @freddyaboulton