Add codecov yaml, round coverage up instead of down #1334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherry
requested review from
bchen1116,
freddyaboulton,
jeremyliweishih and
angela97lin
Codecov Report
@@ Coverage Diff @@
## main #1334 +/- ##
=======================================
Coverage 99.95% 99.95%
=======================================
Files 213 213
Lines 13436 13436
=======================================
Hits 13429 13429
Misses 7 7 Continue to review full report at Codecov.
|
angela97lin
approved these changes
Oct 21, 2020
There was a problem hiding this comment.
Yay, nice! Looks like the default precision is 2 (https://docs.codecov.io/docs/codecov-yaml), but not sure if we have to override everything once we want to customize. Either way, good to specify! LGTM ⚓
|
@angela97lin thanks! Yep I figured it was better to be explicit about that, for once we forget that we added this 😂 |
freddyaboulton
approved these changes
Oct 22, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this will help with some of the codecov precision issues we've been seeing lately. If not, we can continue to tweak.
The default codecov.io precision is 2 -- this just changes to round up instead of down when computing the codecov percentage.