Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codecov yaml, round coverage up instead of down #1334

Merged
merged 3 commits into from Oct 22, 2020
Merged

Conversation

dsherry
Copy link
Collaborator

@dsherry dsherry commented Oct 21, 2020

I think this will help with some of the codecov precision issues we've been seeing lately. If not, we can continue to tweak.

The default codecov.io precision is 2 -- this just changes to round up instead of down when computing the codecov percentage.

@dsherry dsherry added the testing Issues related to testing. label Oct 21, 2020
@codecov
Copy link

codecov bot commented Oct 21, 2020

Codecov Report

Merging #1334 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1334   +/-   ##
=======================================
  Coverage   99.95%   99.95%           
=======================================
  Files         213      213           
  Lines       13436    13436           
=======================================
  Hits        13429    13429           
  Misses          7        7           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2e534f...3525f47. Read the comment docs.

Copy link
Contributor

@angela97lin angela97lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay, nice! Looks like the default precision is 2 (https://docs.codecov.io/docs/codecov-yaml), but not sure if we have to override everything once we want to customize. Either way, good to specify! LGTM

@dsherry
Copy link
Collaborator Author

dsherry commented Oct 21, 2020

@angela97lin thanks! Yep I figured it was better to be explicit about that, for once we forget that we added this 😂

Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dsherry !

@dsherry dsherry merged commit edd91f5 into main Oct 22, 2020
2 checks passed
@dsherry dsherry deleted the ds_codecov branch October 22, 2020 01:08
@dsherry dsherry mentioned this pull request Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Issues related to testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants