Include editable installs in all install make targets #1335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherry
commented
Oct 22, 2020
| @@ -34,7 +34,6 @@ commands: | |||
| - run: | | |||
| virtualenv test_python -q | |||
| source test_python/bin/activate | |||
| make installdeps | |||
There was a problem hiding this comment.
No longer necessary now that make installdeps-dev does editable install
Codecov Report
@@ Coverage Diff @@
## main #1335 +/- ##
=======================================
Coverage 99.95% 99.95%
=======================================
Files 213 213
Lines 13560 13560
=======================================
Hits 13553 13553
Misses 7 7 Continue to review full report at Codecov.
|
dsherry
requested review from
rpeck,
angela97lin,
freddyaboulton,
jeremyliweishih and
bchen1116
jeremyliweishih
approved these changes
Oct 22, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our contributing guide asks people to run
make installdeps-dev, but that doesn't includepip install -e ., which is important! This gave @rpeck some trouble getting the dev env working.