Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include editable installs in all install make targets #1335

Merged
merged 5 commits into from Oct 23, 2020

Conversation

dsherry
Copy link
Collaborator

@dsherry dsherry commented Oct 21, 2020

Our contributing guide asks people to run make installdeps-dev, but that doesn't include pip install -e ., which is important! This gave @rpeck some trouble getting the dev env working.

@dsherry dsherry added the enhancement An improvement to an existing feature. label Oct 21, 2020
@@ -34,7 +34,6 @@ commands:
- run: |
virtualenv test_python -q
source test_python/bin/activate
make installdeps
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer necessary now that make installdeps-dev does editable install

@codecov
Copy link

codecov bot commented Oct 22, 2020

Codecov Report

Merging #1335 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1335   +/-   ##
=======================================
  Coverage   99.95%   99.95%           
=======================================
  Files         213      213           
  Lines       13560    13560           
=======================================
  Hits        13553    13553           
  Misses          7        7           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c40065...e0ca5a0. Read the comment docs.

@dsherry dsherry marked this pull request as ready for review October 22, 2020 00:09
Copy link
Contributor

@angela97lin angela97lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

Copy link
Contributor

@bchen1116 bchen1116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dsherry dsherry merged commit f6a7812 into main Oct 23, 2020
2 checks passed
@dsherry dsherry deleted the ds_update_contributing_guide branch October 23, 2020 14:20
@dsherry dsherry mentioned this pull request Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement to an existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants