Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning on null values for partial_dependency #1352

Merged
merged 6 commits into from Oct 27, 2020
Merged

Conversation

bchen1116
Copy link
Contributor

fix #1285

Warns user when there are null values in the features of interest.

@bchen1116 bchen1116 self-assigned this Oct 27, 2020
@codecov
Copy link

codecov bot commented Oct 27, 2020

Codecov Report

Merging #1352 into main will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1352      +/-   ##
==========================================
+ Coverage   99.95%   99.95%   +0.01%     
==========================================
  Files         213      213              
  Lines       13642    13656      +14     
==========================================
+ Hits        13635    13649      +14     
  Misses          7        7              
Impacted Files Coverage Δ
evalml/exceptions/__init__.py 100.00% <ø> (ø)
evalml/exceptions/exceptions.py 100.00% <100.00%> (ø)
evalml/model_understanding/graphs.py 100.00% <100.00%> (ø)
...lml/tests/model_understanding_tests/test_graphs.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf2c2db...1cd2ef9. Read the comment docs.

@bchen1116 bchen1116 marked this pull request as ready for review October 27, 2020 16:29
Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bchen1116 Looks good to me!

Copy link
Collaborator

@dsherry dsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bchen1116 awesome, left a couple comments but other than that pls 🚢 !

evalml/model_understanding/graphs.py Outdated Show resolved Hide resolved
@bchen1116 bchen1116 merged commit 909cf82 into main Oct 27, 2020
2 checks passed
@dsherry dsherry mentioned this pull request Oct 29, 2020
@freddyaboulton freddyaboulton deleted the bc_1285_partial branch May 13, 2022 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Partial Dependency Fails when feature has nans
3 participants