Adding the Index ID to explain_prediction_best_worst_output #1365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1365 +/- ##
==========================================
+ Coverage 99.95% 99.95% +0.01%
==========================================
Files 213 213
Lines 13929 13938 +9
==========================================
+ Hits 13922 13931 +9
Misses 7 7
Continue to review full report at Codecov.
|
freddyaboulton
force-pushed
the
1119-index-id-best-worst
branch
from
ca1ac0f
to
57c87ff
Compare
freddyaboulton
requested review from
dsherry,
angela97lin,
bchen1116,
christopherbunn,
eccabay,
jeremyliweishih and
gsheni
|
LGTM 🆔 |
bchen1116
reviewed
Oct 30, 2020
| @@ -345,6 +349,7 @@ def test_output_format_checked(): | |||
| Predicted Value: setosa | |||
| Target Value: setosa | |||
| Cross Entropy: 0.15 | |||
| Index ID: {{index_0}} | |||
There was a problem hiding this comment.
why does this have two curly braces?
There was a problem hiding this comment.
We call .format once to format the string with the template for the multiclass shap table (that'll remove the outer curly braces) and then in the test we call .format to format the answer with the expected index (that'll remove the inner curly braces).
bchen1116
approved these changes
Oct 30, 2020
| @@ -426,12 +432,23 @@ def test_explain_predictions_best_worst_and_explain_predictions(mock_make_table, | |||
| pipeline.problem_type = problem_type | |||
| pipeline.name = "Test Pipeline Name" | |||
|
|
|||
| def _add_custom_index(answer, index_best, index_worst, output_format): | |||
freddyaboulton
force-pushed
the
1119-index-id-best-worst
branch
2 times, most recently
from
f121736
to
9ee8ac3
Compare
gsheni
reviewed
Nov 2, 2020
evalml/tests/model_understanding_tests/prediction_explanations_tests/test_explainers.py
Show resolved
Hide resolved
freddyaboulton
force-pushed
the
1119-index-id-best-worst
branch
from
9ee8ac3
to
7471c25
Compare
angela97lin
approved these changes
Nov 3, 2020
|
|
freddyaboulton
force-pushed
the
1119-index-id-best-worst
branch
from
7471c25
to
eae4624
Compare
freddyaboulton
force-pushed
the
1119-index-id-best-worst
branch
from
eae4624
to
b2e3cf9
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fixes #1119.
FYI @RezaAkhtar
After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of
docs/source/release_notes.rstto include this pull request by adding :pr:123.