-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding the Index ID to explain_prediction_best_worst_output #1365
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1365 +/- ##
==========================================
+ Coverage 99.95% 99.95% +0.01%
==========================================
Files 213 213
Lines 13929 13938 +9
==========================================
+ Hits 13922 13931 +9
Misses 7 7
Continue to review full report at Codecov.
|
ca1ac0f
to
57c87ff
Compare
LGTM 🆔 |
@@ -345,6 +349,7 @@ def test_output_format_checked(): | |||
Predicted Value: setosa | |||
Target Value: setosa | |||
Cross Entropy: 0.15 | |||
Index ID: {{index_0}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why does this have two curly braces?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We call .format
once to format the string with the template for the multiclass shap table (that'll remove the outer curly braces) and then in the test we call .format
to format the answer with the expected index (that'll remove the inner curly braces).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@@ -426,12 +432,23 @@ def test_explain_predictions_best_worst_and_explain_predictions(mock_make_table, | |||
pipeline.problem_type = problem_type | |||
pipeline.name = "Test Pipeline Name" | |||
|
|||
def _add_custom_index(answer, index_best, index_worst, output_format): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
f121736
to
9ee8ac3
Compare
evalml/tests/model_understanding_tests/prediction_explanations_tests/test_explainers.py
Show resolved
Hide resolved
9ee8ac3
to
7471c25
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
7471c25
to
eae4624
Compare
eae4624
to
b2e3cf9
Compare
Pull Request Description
Fixes #1119.
FYI @RezaAkhtar
After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of
docs/source/release_notes.rst
to include this pull request by adding :pr:123
.