Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed IndexError when ensembling = True but number of pipelines to search over is 1 #1397

Merged
merged 8 commits into from
Nov 9, 2020

Conversation

angela97lin
Copy link
Contributor

@angela97lin angela97lin commented Nov 2, 2020

Closes #1387

  • Fixes IndexError when number of pipelines to search over == 1
  • Adds a warning that ensembling will not run if num of pipelines == 1

@angela97lin angela97lin self-assigned this Nov 2, 2020
@codecov
Copy link

codecov bot commented Nov 2, 2020

Codecov Report

Merging #1397 (8decbbe) into main (cf50801) will increase coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             main    #1397     +/-   ##
=========================================
+ Coverage   100.0%   100.0%   +0.1%     
=========================================
  Files         214      214             
  Lines       14073    14133     +60     
=========================================
+ Hits        14066    14126     +60     
  Misses          7        7             
Impacted Files Coverage Δ
...lml/automl/automl_algorithm/iterative_algorithm.py 100.0% <100.0%> (ø)
evalml/automl/automl_search.py 99.7% <100.0%> (+0.1%) ⬆️
evalml/tests/automl_tests/test_automl.py 100.0% <100.0%> (ø)
...lml/tests/automl_tests/test_iterative_algorithm.py 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf50801...8decbbe. Read the comment docs.

@CLAassistant
Copy link

CLAassistant commented Nov 2, 2020

CLA assistant check
All committers have signed the CLA.

@angela97lin angela97lin added this to the November 2020 milestone Nov 3, 2020
Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @angela97lin ! I left some minor comments/questions/suggestions.

evalml/tests/automl_tests/test_automl.py Show resolved Hide resolved
evalml/tests/automl_tests/test_iterative_algorithm.py Outdated Show resolved Hide resolved
evalml/automl/automl_algorithm/iterative_algorithm.py Outdated Show resolved Hide resolved
Copy link
Contributor

@bchen1116 bchen1116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

evalml/automl/automl_search.py Outdated Show resolved Hide resolved
@angela97lin angela97lin merged commit 4e2b8fc into main Nov 9, 2020
@angela97lin angela97lin deleted the 1387_fix_stacked_if_len_model_families_1 branch November 9, 2020 19:53
@dsherry dsherry mentioned this pull request Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stacked ensemble breaks if number of allowed pipelines = 1
4 participants