Update AutoML to pass Woodwork DataTables to every pipeline/component (instead of pandas DataFrames) #1450
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1450 +/- ##
=========================================
+ Coverage 100.0% 100.0% +0.1%
=========================================
Files 222 222
Lines 14813 14891 +78
=========================================
+ Hits 14806 14884 +78
Misses 7 7
Continue to review full report at Codecov.
|
| self._set_data_split(X) | ||
|
|
||
| data_checks = self._validate_data_checks(data_checks) | ||
| self._data_check_results = data_checks.validate(X, y) | ||
| self._data_check_results = data_checks.validate(_convert_woodwork_types_wrapper(X.to_dataframe()), _convert_woodwork_types_wrapper(y.to_series())) |
There was a problem hiding this comment.
Data checks currently don't support Woodwork types (to do in #1292 or later PR), so passing pandas to data checks.
angela97lin
requested review from
dsherry,
freddyaboulton,
bchen1116,
christopherbunn,
eccabay and
jeremyliweishih
|
|
||
| if not isinstance(y_true, pd.Series): | ||
| y_true = pd.Series(y_true) | ||
| y_true = self._standardize_input_type(y_true) |
There was a problem hiding this comment.
Updating to reuse our helper method (which handles DataColumns too)
There was a problem hiding this comment.
@angela97lin I think this is great! I noticed none of out automl tests use ww inputs. Not sure if the right thing to do is update all of our tests to use ww, add some ww-specific unit tests, or both but I think we should do at least one before merge lol. In particular, I think we need to be careful that the user-defined types are preserved throughout.
There was a problem hiding this comment.
@angela97lin exciting! Great stuff :)
I left some questions/comments, and one impl suggestion in ObjectiveBase
Closes #1289