Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix high variance cv message for automl #1462

Merged
merged 4 commits into from
Nov 24, 2020
Merged

Fix high variance cv message for automl #1462

merged 4 commits into from
Nov 24, 2020

Conversation

angela97lin
Copy link
Contributor

@angela97lin angela97lin commented Nov 24, 2020 •
edited
Loading

Closes #1280
Fixes the high variance CV message during AutoML after the data checks API update:
image

Currently on main:

image

@angela97lin angela97lin added this to the November 2020 milestone Nov 24, 2020
@angela97lin angela97lin self-assigned this Nov 24, 2020
@codecov
Copy link

codecov bot commented Nov 24, 2020 •
edited
Loading

Codecov Report

Merging #1462 (5254921) into main (ef01e1b) will not change coverage.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1462   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files         223      223           
  Lines       15001    15001           
=======================================
  Hits        14994    14994           
  Misses          7        7
Impacted Files Coverage Δ
evalml/automl/automl_search.py 99.7% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef01e1b...5254921. Read the comment docs.

dsherry
dsherry approved these changes Nov 24, 2020
View reviewed changes
Copy link
Contributor

@dsherry dsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!! 🚢

freddyaboulton
freddyaboulton approved these changes Nov 24, 2020
View reviewed changes
Copy link
Contributor

@freddyaboulton freddyaboulton left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @angela97lin !!

@dsherry
Copy link
Contributor

dsherry commented Nov 24, 2020

@angela97lin does this fix #1280?

@angela97lin
Copy link
Contributor Author

@dsherry I'm not sure what the output looked like before for #1280 but I'd argue it does look well-formatted now so I guess so 👍

@angela97lin angela97lin merged commit ccfd9eb into main Nov 24, 2020
@angela97lin angela97lin deleted the ange_fix_automl_high_variance_cv_message branch November 24, 2020 17:39
@dsherry dsherry mentioned this pull request Nov 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherry dsherry dsherry approved these changes

@freddyaboulton freddyaboulton freddyaboulton approved these changes

Assignees

@angela97lin angela97lin

Labels
None yet
Projects
None yet
Milestone
November 2020
Development

Successfully merging this pull request may close these issues.

Fix logger message for HighVarianceCV Datacheck
3 participants
@angela97lin @dsherry @freddyaboulton