Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting coverage reports in make clean. #1464

merged 2 commits into from Nov 25, 2020


Copy link

Pull Request Description

Over time, developers will accumulate coverage reports if they run make circleci-test or any of the circleci make commands. This modifies make clean to additionally delete these reports as a convenience for developers.

After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of docs/source/release_notes.rst to include this pull request by adding :pr:123.

Copy link

codecov bot commented Nov 24, 2020

Codecov Report

Merging #1464 (1bac772) into main (b8b594f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1464   +/-   ##
  Coverage   100.0%   100.0%           
  Files         223      223           
  Lines       15019    15019           
  Hits        15012    15012           
  Misses          7        7           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8b594f...1bac772. Read the comment docs.

@freddyaboulton freddyaboulton force-pushed the make-clean-deletes-coverage-reports branch from c6241d4 to fd7ab78 Compare November 24, 2020 16:29
Copy link

@angela97lin angela97lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Heh, I never use make circleci-test locally)

@freddyaboulton freddyaboulton merged commit e8dd3ee into main Nov 25, 2020
1 check passed
@dsherry dsherry mentioned this pull request Dec 1, 2020
@freddyaboulton freddyaboulton deleted the make-clean-deletes-coverage-reports branch June 17, 2021 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants