Deleting coverage reports in make clean. #1464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1464 +/- ##
=======================================
Coverage 100.0% 100.0%
=======================================
Files 223 223
Lines 15019 15019
=======================================
Hits 15012 15012
Misses 7 7 Continue to review full report at Codecov.
|
freddyaboulton
force-pushed
the
make-clean-deletes-coverage-reports
branch
from
c6241d4
to
fd7ab78
Compare
freddyaboulton
force-pushed
the
make-clean-deletes-coverage-reports
branch
from
fd7ab78
to
1bac772
Compare
freddyaboulton
requested review from
angela97lin,
bchen1116,
christopherbunn and
ParthivNaresh
angela97lin
approved these changes
Nov 25, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Over time, developers will accumulate coverage reports if they run
make circleci-testor any of the circleci make commands. This modifiesmake cleanto additionally delete these reports as a convenience for developers.After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of
docs/source/release_notes.rstto include this pull request by adding :pr:123.