Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update woodwork to >=0.0.5 for core-requirements.txt #1473

Merged
merged 2 commits into from
Nov 30, 2020

Conversation

angela97lin
Copy link
Contributor

Because Woodwork updated their API from to_pandas to to_series/to_dataframe in 0.0.5, we should update our core-requirements s.t. woodwork >= 0.0.5. Woodwork users for any versions before will run into issues with our library!

@rpeck FYI :)

@angela97lin angela97lin added this to the December 2020 milestone Nov 26, 2020
@angela97lin angela97lin self-assigned this Nov 26, 2020
@codecov
Copy link

codecov bot commented Nov 26, 2020

Codecov Report

Merging #1473 (a36a609) into main (e8dd3ee) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1473   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files         223      223           
  Lines       15019    15019           
=======================================
  Hits        15012    15012           
  Misses          7        7           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8dd3ee...a36a609. Read the comment docs.

Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@angela97lin angela97lin merged commit 94a816d into main Nov 30, 2020
@angela97lin angela97lin deleted the ange_update_ww_core_requirements branch November 30, 2020 16:01
@dsherry dsherry mentioned this pull request Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants