-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding basic outlier detection guardrail #151
Conversation
Codecov Report
@@ Coverage Diff @@
## master #151 +/- ##
==========================================
+ Coverage 96.65% 96.69% +0.03%
==========================================
Files 90 91 +1
Lines 2271 2328 +57
==========================================
+ Hits 2195 2251 +56
- Misses 76 77 +1
Continue to review full report at Codecov.
|
Notes: Also looked into just using IQR but thought that it may not be so great as we increase the number of features. Definitely open to other suggestions! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think we can use IQR as a very basic outlier detection tool but also keep isolation forests as another?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@kmax12 per our brief discussion, should I start moving the guardrails out of Auto(*) classes? Or leave them in there for now? Edit: per discussion, will push in for now and make one PR to remove all guardrails from Auto(*) |
Closes #138