Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed render.py #154

Merged
merged 4 commits into from
Oct 28, 2019
Merged

Removed render.py #154

merged 4 commits into from
Oct 28, 2019

Conversation

christopherbunn
Copy link
Contributor

@christopherbunn christopherbunn commented Oct 24, 2019 •
edited
Loading

Resolves #146

@codecov
Copy link

codecov bot commented Oct 24, 2019 •
edited
Loading

Codecov Report

Merging #154 into master will increase coverage by 1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #154   +/-   ##
=======================================
+ Coverage   94.51%   95.52%   +1%     
=======================================
  Files          58       57    -1     
  Lines        1514     1498   -16     
=======================================
  Hits         1431     1431           
+ Misses         83       67   -16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b91b3a7...d3c4c5a. Read the comment docs.

kmax12
kmax12 approved these changes Oct 28, 2019
View reviewed changes
Copy link
Contributor

@kmax12 kmax12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christopherbunn christopherbunn merged commit 7b7dbd1 into master Oct 28, 2019
@christopherbunn christopherbunn deleted the remove-render branch October 28, 2019 19:59
@angela97lin angela97lin mentioned this pull request Oct 29, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmax12 kmax12 kmax12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clean up old render functions that aren't used
2 participants
@christopherbunn @kmax12