New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add save_plot to save graphs to file #1588
Merged
Merged
Changes from 38 commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
754ab13
Requirements
ParthivNaresh e831be0
Tests
ParthivNaresh 2b45482
Save graph to file
ParthivNaresh 6f1f75e
Merge branch 'main' into 1535-save-graphs-to-file
ParthivNaresh a5598c0
Kaleido requirement update
ParthivNaresh 1a54641
Save graph
ParthivNaresh 3612c0e
Testing all figure types and filepaths
ParthivNaresh 345af0f
Removed Kaleido
ParthivNaresh b8870ce
Updated release_notes.rst
ParthivNaresh 1f72ccc
Added Kaleido
ParthivNaresh d116f6a
Requirements added: seaborn and kaleido
ParthivNaresh af8084b
test update
ParthivNaresh 7c1b02d
Test updates
ParthivNaresh e7ee05a
Merge branch 'main' into 1535-save-graphs-to-file
ParthivNaresh 7029a16
Replace seaborn test check
ParthivNaresh 4cc15e8
Docstring update
ParthivNaresh f4bf24c
Changed Target Encoder to OHE
ParthivNaresh 907549c
Merge branch 'main' into 1535-save-graphs-to-file
ParthivNaresh 733d30f
Edited tests to skip missing dependencies, and added matplotlib to re…
ParthivNaresh 05f3a93
Cleaner tests and added matplotlib to latest_dependeny_versions.txt
ParthivNaresh c5bb016
Updates
ParthivNaresh 88e76ec
Test updates
ParthivNaresh a153595
Added coverage for None filepath
ParthivNaresh 2438181
Merge branch 'main' into 1535-save-graphs-to-file
ParthivNaresh 66bbfe4
Updated default format pdf for graphviz
ParthivNaresh 7208901
png default for graphviz
ParthivNaresh 78d85a9
Release notes
ParthivNaresh 674b4c1
Merge branch 'main' into 1535-save-graph-v2
ParthivNaresh 2dbe665
remove kaleido
ParthivNaresh e945467
Added Python Kaleido
ParthivNaresh 91f1d87
Merge branch 'main' into Update_Default_Graphviz_Format
ParthivNaresh 464e0f3
Release notes
ParthivNaresh 2461a69
Moved release notes from fixes to enhancements
ParthivNaresh 961b23d
Update DOCKER_CONTAINERID to reflect changes made in Feedstock to sup…
ParthivNaresh b2e1706
Added seaborn and matplotlib
ParthivNaresh 309334d
Seaborn update
ParthivNaresh 84a678a
Seaborn change to 0.11.0
ParthivNaresh 0f1ada1
Put latest_dependency_versions in alphabetical order
ParthivNaresh c880d92
Merge branch 'main' into Update_Default_Graphviz_Format
ParthivNaresh File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,11 @@ | ||
-r core-requirements.txt | ||
plotly>=4.2.1 | ||
plotly>=4.14.0 | ||
kaleido>=0.1.0 | ||
ipywidgets>=7.5 | ||
xgboost>=0.82,<1.3.0 | ||
catboost>=0.20 | ||
lightgbm>=2.3.1 | ||
matplotlib>=3.3.3 | ||
graphviz>=0.13 | ||
seaborn>=0.11.1 | ||
category_encoders>=2.0.0 |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we need to change the docker image we use in our conda-check because
python-kaleido
requires a centOS docker image.This reflects this change we had to make to our conda recipe.
I tested this change locally by checking out this branch and running our conda build steps manually. Tests pass and the build succeeds!