wip: addressing comments #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## pipeline_v2 #159 +/- ##
==============================================
Coverage ? 96.58%
==============================================
Files ? 88
Lines ? 2140
Branches ? 0
==============================================
Hits ? 2067
Misses ? 73
Partials ? 0
Continue to review full report at Codecov.
|
angela97lin
commented
Oct 29, 2019
|
Note: currently investigating scikit-learn/scikit-learn#5523 |
…ents in DEFAULT_COMPONENTS
jeremyliweishih
requested changes
Oct 31, 2019
jeremyliweishih
approved these changes
Oct 31, 2019
angela97lin
added a commit
that referenced
this pull request
Nov 4, 2019
* adding skeleton for component_base * oops, added nested components folders, fixing * linting * adding skeleton estimator/transfomer classes * adding basic estimator components for merge merge * WIP: Components (#107) * Added imputer * Clean up imputer * added onehot and standard scaler * Need fix selectfrommodel and validating * Add selectfrommodel * Cleanup and added basic init test * lint * cleaning up, more merging, combining tests * adding componenttype enum, a little more merging * linting * Moved to estimator * lint fix :P * pipeline v2 base * pushing new base for pipeline and simple test * Faulty scaler for LR * Working LR * Broken RF * Fixed SelectFromModel * Added RF pipeline Fixed SelectFromModel * changing xgboost to use our components * Added RF Regression * beginning to fix broken pieces * continuing to fix tests * fixing tests in autoclassifier * linting * fixing silly typo bug * linting * cleaning up pipeline and pipelinebase classes * adding describe to components and pipeline * linting and fixing minor bug * adding check for estimator in pipeline * Pipeline indexing (#118) * Added indexing and basic tests * Switched to pipelinebase for slicing * Clean up and add docstrings * lint * lint again * Clean up and add error for setting * adding default value to next() to prevent StopIteration error * oops, actually fixing... * fixing docstrings and cleaning imports * adding simple tests for describe * linting * Autogenerated pipeline names (#122) * Basic name without check * Add assert * lint * Changed name format and name constants * Cleanup * moving files to subfolders and removing hyperparameters as class var * updating file hierarchy * linting * removing duplicate * Add feature_importance tests * adding extra tests * adding test, cleanup * Added linear regression and test for pipeling fitting (#131) * Added linear regression pipeline and added test for fitting * Remove unnecessary fit for xgboost component (#148) * Remove fit for xgboost * Remove kwargs * addressing pr comments: rename, abstract feature_importances, del __init__, cleanup, etc. (#149) * addressing pr comments: rename, del __init__, cleanup * cleaning up describe * feature importances + cleanup of components, added subclasses encoder + feature_selector * linting, fixing errors * adding less specific version * addressing comments * import errors * String and component_type component (#153) * added handling str and component type for component list * Adding model_type / problem_type to PipelineBase to allow inference (#157) * adding problem_type and model_type to pipeline base * problem_type --> problem_types * cleaning up self.component_list and init pipeline, typo * forgot to remove print * removing comments * changelog * removing generic SelectFromModel * Jeremy changes (#164) * cleanup components utils * Switch to category_encoder and cleanup RF Select * add feature_importance to estimator * More switching to CE * Move parameters to class attributes and make test * lint * Separate changelog test * Text cleanup * wip: addressing comments (#159) * wip: addressing comments * feature names? * adding fix for no estimator in generate_name * fixing test * addressing more comments on feature_importance * feature_importances fixed and cleaned :) * oops, missed merge conflict * change of name * minor cleanup * adding basic test for two feature selectors and adding default components in DEFAULT_COMPONENTS * adding tests for retaining feature names in input_feature_names * addressing comments * cleanup * fixing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing comments for Pipeline v2.0 PR (#108)