Add support for scipy v1.6.0 #1752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1752 +/- ##
=======================================
Coverage 100.0% 100.0%
=======================================
Files 243 243
Lines 19445 19445
=======================================
Hits 19436 19436
Misses 9 9 Continue to review full report at Codecov.
|
angela97lin
requested review from
dsherry,
freddyaboulton,
bchen1116,
chukarsten and
ParthivNaresh
freddyaboulton
approved these changes
Jan 28, 2021
There was a problem hiding this comment.
@angela97lin Looks great! Glad the sklearn update PR made this possible.
chukarsten
approved these changes
Jan 28, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1630.
After adding support for
scikit-learn>=0.24.0in #1733, EvalML now installs the a version ofscikit-learn>=0.24.0, which solves the previous issue that disallowed us to add support forscipy1.6.0, described here: #1630 (comment)However, I think it's okay to not have a hard requirement for
scikit-learn>=0.24.0though, since it was a really specific case with a specific random state and LogisticRegressionClassifier not converging so users with previous versions are not necessarily blocked / unable to use EvalML.