Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for scipy v1.6.0 #1752

merged 6 commits into from
Jan 28, 2021

Add support for scipy v1.6.0 #1752

merged 6 commits into from
Jan 28, 2021


Copy link

@angela97lin angela97lin commented Jan 27, 2021

Closes #1630.

After adding support for scikit-learn >=0.24.0 in #1733, EvalML now installs the a version of scikit-learn >=0.24.0, which solves the previous issue that disallowed us to add support for scipy 1.6.0, described here: #1630 (comment)

However, I think it's okay to not have a hard requirement for scikit-learn>=0.24.0 though, since it was a really specific case with a specific random state and LogisticRegressionClassifier not converging so users with previous versions are not necessarily blocked / unable to use EvalML.

Copy link

codecov bot commented Jan 27, 2021

Codecov Report

Merging #1752 (268f9ec) into main (1166ec2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1752   +/-   ##
  Coverage   100.0%   100.0%           
  Files         243      243           
  Lines       19445    19445           
  Hits        19436    19436           
  Misses          9        9           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1166ec2...268f9ec. Read the comment docs.

Copy link

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@angela97lin Looks great! Glad the sklearn update PR made this possible.

@angela97lin angela97lin added this to the Sprint 2021 Jan B milestone Jan 28, 2021
@angela97lin angela97lin merged commit 6f4a55b into main Jan 28, 2021
@angela97lin angela97lin deleted the 1630_scipy_1.6.0 branch January 28, 2021 21:37
@chukarsten chukarsten mentioned this pull request Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Integrate scipy version 1.6.0
3 participants