Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving some prs from 0.18.1 release notes to future release section. #1789

Merged
merged 3 commits into from
Feb 4, 2021

Conversation

freddyaboulton
Copy link
Contributor

Pull Request Description

I think some prs were incorrectly added to the 0.18.1 release notes. Moving them to the "Future Release" section. Let me know if I'm mistaken!


After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of docs/source/release_notes.rst to include this pull request by adding :pr:123.

Copy link
Contributor

@angela97lin angela97lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooops haha good catch! Thank you 😁

Copy link
Collaborator

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link
Contributor

@bchen1116 bchen1116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Feb 4, 2021

Codecov Report

Merging #1789 (ca5f5ef) into main (ed6a770) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1789   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files         247      247           
  Lines       19679    19679           
=======================================
  Hits        19670    19670           
  Misses          9        9           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed6a770...ca5f5ef. Read the comment docs.

@freddyaboulton freddyaboulton merged commit 9b39336 into main Feb 4, 2021
@ParthivNaresh ParthivNaresh mentioned this pull request Feb 9, 2021
@freddyaboulton freddyaboulton deleted the fix-0.18.1-release-notes branch June 17, 2021 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants