Skip to content

Moving some prs from 0.18.1 release notes to future release section.#1789

Merged
freddyaboulton merged 3 commits into
mainfrom
fix-0.18.1-release-notes
Feb 4, 2021
Merged

Moving some prs from 0.18.1 release notes to future release section.#1789
freddyaboulton merged 3 commits into
mainfrom
fix-0.18.1-release-notes

Conversation

@freddyaboulton
Copy link
Copy Markdown
Contributor

Pull Request Description

I think some prs were incorrectly added to the 0.18.1 release notes. Moving them to the "Future Release" section. Let me know if I'm mistaken!


After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of docs/source/release_notes.rst to include this pull request by adding :pr:123.

Copy link
Copy Markdown
Contributor

@angela97lin angela97lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooops haha good catch! Thank you 😁

Copy link
Copy Markdown
Collaborator

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link
Copy Markdown
Contributor

@bchen1116 bchen1116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 4, 2021

Codecov Report

Merging #1789 (ca5f5ef) into main (ed6a770) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1789   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files         247      247           
  Lines       19679    19679           
=======================================
  Hits        19670    19670           
  Misses          9        9           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed6a770...ca5f5ef. Read the comment docs.

@freddyaboulton freddyaboulton merged commit 9b39336 into main Feb 4, 2021
@ParthivNaresh ParthivNaresh mentioned this pull request Feb 9, 2021
@freddyaboulton freddyaboulton deleted the fix-0.18.1-release-notes branch June 17, 2021 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants