Adding deprecation warning to explain_prediction. #1860
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1860 +/- ##
=========================================
+ Coverage 100.0% 100.0% +0.1%
=========================================
Files 260 260
Lines 20832 20838 +6
=========================================
+ Hits 20826 20832 +6
Misses 6 6
Continue to review full report at Codecov.
|
freddyaboulton
force-pushed
the
1822-deprecate-explain_prediction
branch
from
33e008f
to
7a0687a
Compare
freddyaboulton
requested review from
chukarsten,
angela97lin,
bchen1116,
jeremyliweishih and
ParthivNaresh
| @@ -25,6 +25,11 @@ Release Notes | |||
| * Pin graphviz version for windows builds :pr:`1847` | |||
| * Unpin graphviz version for windows builds :pr:`1851` | |||
|
|
|||
| .. warning:: | |||
|
|
|||
| **Breaking Changes** | |||
There was a problem hiding this comment.
This is only listed as a breaking change but not in the other sections of the release notes? :O Is this intentional 👀
There was a problem hiding this comment.
I originally had it in both but then felt it was redundant. Do we have a guideline in place for this?
There was a problem hiding this comment.
To date, we've listed in both places. And a single PR could contain multiple lines of change in release notes. However for something this small, I think this is fine.
|
@angela97lin Yes! We have #1832 |
|
@freddyaboulton Amazing, didn't realize it was filed a while ago. Thank you! |
freddyaboulton
force-pushed
the
1822-deprecate-explain_prediction
branch
from
7a0687a
to
6318ba1
Compare
|
Passing RTD build here. |
|
Pull Request Description
Fixes #1822
After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of
docs/source/release_notes.rstto include this pull request by adding :pr:123.