Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating readthedocs to successfully build #188

Merged
merged 2 commits into from Nov 6, 2019
Merged

Updating readthedocs to successfully build #188

merged 2 commits into from Nov 6, 2019

Conversation

angela97lin
Copy link
Contributor

@angela97lin angela97lin commented Nov 5, 2019

Updating readthedocs.yaml to successfully build

@@ -17,6 +17,8 @@ formats: all

# Optionally set the version of Python and requirements required to build your docs
python:
version: 3.5
version: 3.7
Copy link
Contributor Author

@angela97lin angela97lin Nov 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think updating version is actually necessary to build, but figured it doesn't hurt?

Copy link
Contributor

@kmax12 kmax12 Nov 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me

kmax12
kmax12 approved these changes Nov 5, 2019
Copy link
Contributor

@kmax12 kmax12 left a comment

seems like it's building correctly: https://evalml.featurelabs.com/en/rtd/roadmap.html

LGTM

@codecov
Copy link

codecov bot commented Nov 5, 2019

Codecov Report

Merging #188 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #188   +/-   ##
=======================================
  Coverage   96.65%   96.65%           
=======================================
  Files          90       90           
  Lines        2271     2271           
=======================================
  Hits         2195     2195           
  Misses         76       76

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9525b3f...c84d030. Read the comment docs.

@angela97lin angela97lin merged commit c8fbbb9 into master Nov 6, 2019
@angela97lin angela97lin self-assigned this Nov 6, 2019
@angela97lin angela97lin mentioned this pull request Nov 15, 2019
@angela97lin angela97lin deleted the rtd branch Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants