Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reversing the GitHub Action for Linux Unit Tests #1920

Merged
merged 3 commits into from Mar 3, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
80 changes: 80 additions & 0 deletions .circleci/config.yml
Expand Up @@ -38,6 +38,18 @@ commands:
virtualenv test_python -q
source test_python/bin/activate
make installdeps-docs
install_dependencies_core:
steps:
- run: |
virtualenv test_python -q
source test_python/bin/activate
pip install --upgrade pip -q
pip install -e . --no-dependencies
pip install -r core-requirements.txt
pip install -r test-requirements.txt
# "!" negates return code. exit nonzero if any of these deps are found
! pip freeze | grep -E "xgboost|catboost|lightgbm|plotly|ipywidgets|category_encoders"
exit $?
build_pkg:
steps:
- run: |
Expand Down Expand Up @@ -74,6 +86,58 @@ jobs:
- setup_remote_docker:
version: 19.03.12
- build_pkg
unit_tests:
resource_class: xlarge
parameters:
python_version:
type: string
default: "3.8"
codecov:
type: boolean
default: false
core_dependencies:
type: boolean
default: false
executor:
name: python
python_version: << parameters.python_version >>
steps:
- run: sudo apt update && sudo apt install -y graphviz
- checkout
- when:
condition: << parameters.core_dependencies >>
steps:
- install_dependencies_core
- unless:
condition: << parameters.core_dependencies >>
steps:
- install_dependencies
- install_dependencies_test
- run: |
source test_python/bin/activate
coverage erase
- when:
condition: << parameters.core_dependencies >>
steps:
- run: |
source test_python/bin/activate
make git-test-minimal-deps
- unless:
condition: << parameters.core_dependencies >>
steps:
- run: |
source test_python/bin/activate
make git-test
- store_test_results:
path: test-reports
- store_artifacts:
path: test-reports
- when:
condition: << parameters.codecov >>
steps:
- run: |
source test_python/bin/activate
codecov --required
build_docs:
working_directory: ~/evalml/
executor:
Expand Down Expand Up @@ -130,6 +194,22 @@ workflows:
filters:
branches:
ignore: /^main?/
test_all_python_versions:
jobs:
- unit_tests:
matrix:
parameters:
python_version: [ "3.7" ]
core_dependencies: [ false ]
codecov: [ false ]
name: "linux python << matrix.python_version >> unit tests, core dependencies << matrix.core_dependencies >>, codecov << matrix.codecov >>"
- unit_tests:
matrix:
parameters:
python_version: [ "3.8" ]
core_dependencies: [ false, true ]
codecov: [ true ]
name: "linux python << matrix.python_version >> unit tests, core dependencies << matrix.core_dependencies >>, codecov << matrix.codecov >>"
build_conda_pkg:
jobs:
- shellcheck/check
Expand Down
3 changes: 0 additions & 3 deletions .coveragerc
@@ -1,6 +1,3 @@
[run]
source=evalml

[report]
exclude_lines =
pragma: no cover
79 changes: 0 additions & 79 deletions .github/workflows/linux_unit_tests.yml

This file was deleted.

1 change: 1 addition & 0 deletions docs/source/release_notes.rst
Expand Up @@ -10,6 +10,7 @@ Release Notes
* Added metaclass for time series pipelines and fix binary classification pipeline ``predict`` not using objective if it is passed as a named argument :pr:`1874`
* Fixed stack trace in prediction explanation functions caused by mixed string/numeric pandas column names :pr:`1871`
* Changes
* Reversed GitHub Action for Linux unit tests until a fix for report generation is found :pr:`1920`
* Updated ``add_results`` in ``AutoMLAlgorithm`` to take in entire pipeline results dictionary from ``AutoMLSearch`` :pr:`1891`
* Updated ``ClassImbalanceDataCheck`` to look for severe class imbalance scenarios :pr:`1905`
* Documentation Changes
Expand Down
2 changes: 1 addition & 1 deletion test-requirements.txt
Expand Up @@ -3,5 +3,5 @@ pytest-xdist==1.26.1
pytest-cov==2.6.1
nbval==0.9.3
IPython>=5.0.0
codecov==2.1.8
codecov==2.1.0
PyYAML==5.3.1