Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing guardrails from Auto(*) #202

Merged
merged 2 commits into from Nov 11, 2019
Merged

removing guardrails from Auto(*) #202

merged 2 commits into from Nov 11, 2019

Conversation

angela97lin
Copy link
Contributor

@angela97lin angela97lin commented Nov 11, 2019

removing guardrails from Auto(*)

closes #201

@angela97lin angela97lin self-assigned this Nov 11, 2019
@codecov
Copy link

codecov bot commented Nov 11, 2019

Codecov Report

Merging #202 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #202      +/-   ##
==========================================
+ Coverage   96.69%   96.73%   +0.04%     
==========================================
  Files          91       91              
  Lines        2328     2298      -30     
==========================================
- Hits         2251     2223      -28     
+ Misses         77       75       -2
Impacted Files Coverage Δ
evalml/models/auto_base.py 93.77% <ø> (+0.41%) ⬆️
evalml/models/auto_regressor.py 90.9% <ø> (ø) ⬆️
evalml/tests/automl_tests/test_autoclassifier.py 100% <ø> (ø) ⬆️
evalml/models/auto_classifier.py 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71cd00d...19ef412. Read the comment docs.

@angela97lin angela97lin requested review from kmax12 and jeremyliweishih and removed request for kmax12 Nov 11, 2019
@angela97lin
Copy link
Contributor Author

angela97lin commented Nov 11, 2019

Note: not sure if we should remove label leakage as well, since it's a guardrail but was implemented before.

kmax12
kmax12 approved these changes Nov 11, 2019
Copy link
Contributor

@kmax12 kmax12 left a comment

LGTM

@angela97lin angela97lin merged commit 7b6eff0 into master Nov 11, 2019
@angela97lin angela97lin mentioned this pull request Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove guardrails from Auto(*)
2 participants