Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correcting random_state passed to pipelines #204

Merged
merged 8 commits into from Nov 12, 2019
Merged

Correcting random_state passed to pipelines #204

merged 8 commits into from Nov 12, 2019

Conversation

angela97lin
Copy link
Contributor

@angela97lin angela97lin commented Nov 11, 2019

There's a bug where random_state (and n_jobs) were not correctly passed to the PipelineBase constructor; fixing and adding test cases here.

@angela97lin angela97lin changed the title rs Correcting random_state passed to pipelines Nov 11, 2019
@codecov
Copy link

codecov bot commented Nov 11, 2019

Codecov Report

Merging #204 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #204      +/-   ##
==========================================
+ Coverage   96.73%   96.78%   +0.04%     
==========================================
  Files          91       91              
  Lines        2298     2333      +35     
==========================================
+ Hits         2223     2258      +35     
  Misses         75       75
Impacted Files Coverage Δ
evalml/pipelines/regression/linear_regression.py 100% <ø> (ø) ⬆️
evalml/pipelines/classification/random_forest.py 100% <ø> (ø) ⬆️
...ml/pipelines/classification/logistic_regression.py 100% <ø> (ø) ⬆️
evalml/pipelines/classification/xgboost.py 100% <ø> (ø) ⬆️
evalml/pipelines/regression/random_forest.py 100% <ø> (ø) ⬆️
...l/tests/pipeline_tests/test_logistic_regression.py 100% <100%> (ø) ⬆️
...lml/tests/pipeline_tests/test_linear_regression.py 100% <100%> (ø) ⬆️
evalml/tests/pipeline_tests/test_xgboost.py 100% <100%> (ø) ⬆️
evalml/tests/pipeline_tests/test_rf.py 100% <100%> (ø) ⬆️
evalml/pipelines/pipeline_base.py 97.05% <100%> (ø) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 116392b...e315c01. Read the comment docs.

@angela97lin angela97lin requested a review from kmax12 Nov 11, 2019
Copy link
Contributor

@jeremyliweishih jeremyliweishih left a comment

LGTM maybe wait on @kmax12 thoughts on the default values.

evalml/pipelines/pipeline_base.py Show resolved Hide resolved
kmax12
kmax12 previously approved these changes Nov 12, 2019
Copy link
Contributor

@kmax12 kmax12 left a comment

Good catch. LGTM

kmax12
kmax12 approved these changes Nov 12, 2019
@angela97lin angela97lin merged commit 247a546 into master Nov 12, 2019
@angela97lin angela97lin deleted the random branch Nov 12, 2019
@angela97lin angela97lin mentioned this pull request Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants