-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correcting random_state passed to pipelines #204
Conversation
Codecov Report
@@ Coverage Diff @@
## master #204 +/- ##
==========================================
+ Coverage 96.73% 96.78% +0.04%
==========================================
Files 91 91
Lines 2298 2333 +35
==========================================
+ Hits 2223 2258 +35
Misses 75 75
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM maybe wait on @kmax12 thoughts on the default values.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. LGTM
There's a bug where random_state (and n_jobs) were not correctly passed to the PipelineBase constructor; fixing and adding test cases here.