Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added contribute to EvalML instructions #213

Merged
merged 7 commits into from
Nov 15, 2019
Merged

Added contribute to EvalML instructions #213

merged 7 commits into from
Nov 15, 2019

Conversation

jeremyliweishih
Copy link
Contributor

Added contributing instructions.

kmax12
kmax12 previously approved these changes Nov 14, 2019
Copy link
Contributor

@kmax12 kmax12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this is a good start. let's have @angela97lin review before merging when she's back. then we can test run it with dylan next week

contributing.md Outdated
* install in edit mode with:
```bash
cd evalml # move to directory
pip install -e . # install in edit mode
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we have make installdeps which can be used for development installation

@codecov
Copy link

codecov bot commented Nov 14, 2019

Codecov Report

Merging #213 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #213   +/-   ##
=======================================
  Coverage   96.77%   96.77%           
=======================================
  Files          91       91           
  Lines        2354     2354           
=======================================
  Hits         2278     2278           
  Misses         76       76

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91e07ab...1d60c37. Read the comment docs.

contributing.md Outdated Show resolved Hide resolved
contributing.md Outdated Show resolved Hide resolved
contributing.md Outdated Show resolved Hide resolved
contributing.md Outdated Show resolved Hide resolved
contributing.md Outdated Show resolved Hide resolved
Copy link
Contributor

@angela97lin angela97lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some minor comments but otherwise LGTM! Would definitely be great to have Dylan test-run and make comments too :)

Copy link
Contributor

@angela97lin angela97lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

@jeremyliweishih jeremyliweishih merged commit 3535564 into master Nov 15, 2019
@angela97lin angela97lin mentioned this pull request Nov 15, 2019
@dsherry dsherry deleted the contribute branch May 26, 2020 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants