Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add top-level search method #2152

Merged
merged 11 commits into from May 3, 2021
Merged

Add top-level search method #2152

merged 11 commits into from May 3, 2021

Conversation

dsherry
Copy link
Contributor

@dsherry dsherry commented Apr 16, 2021

First draft of a top-level search method. This method is our recommendation for how to use woodwork, data checks and automl search together. It defines an interface which sets up the woodwork schema (if the input didn't already set woodwork types), runs our default data checks and then if there are no errors runs automl search.

Once data check actions have been added, we can add support for that here as well.

@dsherry dsherry added the new feature Features which don't yet exist. label Apr 16, 2021
@dsherry dsherry changed the title Add top-level search method Spike: add top-level search method Apr 16, 2021
@codecov
Copy link

codecov bot commented Apr 16, 2021

Codecov Report

Merging #2152 (5abe600) into main (838da3c) will increase coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             main    #2152     +/-   ##
=========================================
+ Coverage   100.0%   100.0%   +0.1%     
=========================================
  Files         287      288      +1     
  Lines       24399    24449     +50     
=========================================
+ Hits        24381    24431     +50     
  Misses         18       18             
Impacted Files Coverage Δ
evalml/__init__.py 100.0% <100.0%> (ø)
evalml/automl/__init__.py 100.0% <100.0%> (ø)
evalml/automl/automl_search.py 100.0% <100.0%> (ø)
evalml/tests/automl_tests/test_search.py 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 838da3c...5abe600. Read the comment docs.

@dsherry dsherry changed the title Spike: add top-level search method Add top-level search method Apr 28, 2021
@dsherry dsherry marked this pull request as ready for review April 30, 2021 14:35
Copy link
Contributor

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just had some comments on docstring updates.

evalml/automl/automl_search.py Outdated Show resolved Hide resolved
evalml/automl/automl_search.py Show resolved Hide resolved
@dsherry dsherry merged commit 48ab46a into main May 3, 2021
@chukarsten chukarsten mentioned this pull request May 4, 2021
@chukarsten chukarsten mentioned this pull request May 4, 2021
@freddyaboulton freddyaboulton deleted the ds_spike_search_method branch May 13, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Features which don't yet exist.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants