Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change minimum unit tests to run on all PRs #2314

merged 8 commits into from Jun 4, 2021


Copy link

@gsheni gsheni commented May 28, 2021

No description provided.

@gsheni gsheni self-assigned this May 28, 2021
Copy link

codecov bot commented May 28, 2021

Codecov Report

Merging #2314 (4c621af) into main (9b8b4a6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2314   +/-   ##
  Coverage   99.9%   99.9%           
  Files        281     281           
  Lines      24607   24607           
  Hits       24578   24578           
  Misses        29      29           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b8b4a6...4c621af. Read the comment docs.

Copy link

@dsherry @ParthivNaresh I picked up where @gsheni left off. This should be ready for a second review now!

Copy link

@ParthivNaresh ParthivNaresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Quick question, does removing the paths make a difference here? Those paths would always be available for the CI to be triggered off of right?

Copy link
Contributor Author

gsheni commented Jun 4, 2021

@ParthivNaresh the paths made it so the workflow would only be trigger if it was a PR and those filepaths were changed (as compared to main)

Copy link

@gsheni Ahh correct I misread that part of the docs, sounds great!

@freddyaboulton freddyaboulton merged commit 76effdf into main Jun 4, 2021
@freddyaboulton freddyaboulton deleted the run_on_min_unit branch June 4, 2021 17:02
@chukarsten chukarsten mentioned this pull request Jun 9, 2021
@chukarsten chukarsten mentioned this pull request Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

4 participants