Minor PipelineBase cleanup: remove _compute_features_during_fit
#2359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2359 +/- ##
=======================================
- Coverage 99.7% 99.7% -0.0%
=======================================
Files 281 281
Lines 24926 24923 -3
=======================================
- Hits 24829 24826 -3
Misses 97 97
Continue to review full report at Codecov.
|
angela97lin
commented
Jun 10, 2021
| @@ -78,7 +78,10 @@ def fit(self, X, y): | |||
| X, y = self._convert_to_woodwork(X, y) | |||
| self._encoder.fit(y) | |||
| y = self._encode_targets(y) | |||
| X_t = self._compute_features_during_fit(X, y) | |||
There was a problem hiding this comment.
I thought this was confusing because we called self.input_feature_names = self.component_graph.input_feature_names in _compute_features_during_fit and then again below! Moving just these two lines here helps remove the redundancy.
angela97lin
changed the title
PipelineBase cleanup: remove _compute_features_during_fit
angela97lin
requested review from
freddyaboulton,
chukarsten,
bchen1116,
jeremyliweishih and
ParthivNaresh
jeremyliweishih
approved these changes
Jun 10, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed
_compute_features_during_fitbecause we calledself.input_feature_names = self.component_graph.input_feature_namesin_compute_features_during_fitand then again before returning in the time-series regression pipelines'fitmethod. Moving just these two lines here helps remove the redundancy and avoid bugs with setting the attribute twice.