Skip to content

Conversation

@christopherbunn
Copy link
Contributor

@christopherbunn christopherbunn commented Aug 2, 2021

Renaming existing ensembler component to clarify it is sklearn based and to differentiate it from the new ensembler component.

@codecov
Copy link

codecov bot commented Aug 2, 2021

Codecov Report

Merging #2578 (0731e22) into main (455210b) will not change coverage.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2578   +/-   ##
=====================================
  Coverage   99.9%   99.9%           
=====================================
  Files        295     295           
  Lines      27055   27055           
=====================================
  Hits       27012   27012           
  Misses        43      43           
Impacted Files Coverage Δ
evalml/pipelines/__init__.py 100.0% <ø> (ø)
evalml/pipelines/pipeline_base.py 98.3% <ø> (ø)
evalml/tests/automl_tests/test_evalml_algorithm.py 100.0% <ø> (ø)
evalml/utils/gen_utils.py 99.6% <ø> (ø)
evalml/pipelines/components/__init__.py 100.0% <100.0%> (ø)
evalml/pipelines/components/ensemble/__init__.py 100.0% <100.0%> (ø)
...mponents/ensemble/sklearn_stacked_ensemble_base.py 100.0% <100.0%> (ø)
...ts/ensemble/sklearn_stacked_ensemble_classifier.py 100.0% <100.0%> (ø)
...nts/ensemble/sklearn_stacked_ensemble_regressor.py 100.0% <100.0%> (ø)
evalml/pipelines/utils.py 99.2% <100.0%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 455210b...0731e22. Read the comment docs.

@christopherbunn christopherbunn changed the title Appended Sklearn to existing ensembler implementation Rename existing ensembler implementation from StackedEnsemblers to SklearnStackedEnsemblers Aug 3, 2021
@christopherbunn christopherbunn marked this pull request as ready for review August 3, 2021 15:55
Copy link
Contributor

@chukarsten chukarsten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@christopherbunn christopherbunn merged commit 8205966 into main Aug 4, 2021
@freddyaboulton freddyaboulton deleted the cb_ensembler_spike branch May 13, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants