Repository navigation
Update pipeline graph() to label edges with X, y or both - #2654
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2654 +/- ##
=======================================
+ Coverage 99.9% 99.9% +0.1%
=======================================
Files 300 300
Lines 27426 27439 +13
=======================================
+ Hits 27382 27395 +13
Misses 44 44
Continue to review full report at Codecov.
|
|
couple suggestions but not sure if this is achievable in graphviz:
|
|
@angela97lin Agree with @jeremyliweishih that the edge labels are overwhelming! I like his suggestion. If that's not possible with graphviz, maybe we can instead skip the labels that are coming from the original input |
|
I'm a little confused, should the output of TargetImputer be like "TargetImputer.y" indicating that that component has acted upon y? Same question for Imputer with X. I think if you don't see that change in the labels, then I wonder what the labels are really conveying. |
|
@chukarsten I think your confusion stems from the labelling, which I'm going to remove. The X and y refer to "this target is connected to that component's target input" but does not actually specify what the target value is. |
eccabay
left a comment
There was a problem hiding this comment.
LGTM! I like the solid vs dotted lines, and I think it's a great step in the right direction as we look into moving away from graphviz in the future.
| * Add ``ProphetRegressor`` to AutoML :pr:`2619` | ||
| * Removed SVM "linear" and "precomputed" kernel hyperparameter options, and improved default parameters :pr:`2651` | ||
| * Updated ``ComponentGraph`` initalization to raise ``ValueError`` when user attempts to use ``.y`` for a component that does not produce a tuple output :pr:`2662` | ||
| * Updated pipeline ``graph()`` to label edges with X, y or both :pr:`2654` |
There was a problem hiding this comment.
This is no longer true since the edges aren't labeled, just dotted/not!
bchen1116
left a comment
There was a problem hiding this comment.
LGTM! I like the dotted and solid lines here compared to the previous iteration. Great work getting it done and iterating on this!


Closes #1962
The current prototype:
I wasn't able to find a great way to create a nice-looking legend, so here's the current prototype, seeking feedback / opinions 👀