Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky CFEngine Test #2666

Merged
merged 5 commits into from
Aug 23, 2021
Merged

Flaky CFEngine Test #2666

merged 5 commits into from
Aug 23, 2021

Conversation

chukarsten
Copy link
Contributor

Fixes #2582

@codecov
Copy link

codecov bot commented Aug 20, 2021

Codecov Report

Merging #2666 (702d987) into main (22dd02c) will not change coverage.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2666   +/-   ##
=====================================
  Coverage   99.9%   99.9%           
=====================================
  Files        298     298           
  Lines      27305   27305           
=====================================
  Hits       27261   27261           
  Misses        44      44           
Impacted Files Coverage Δ
...ests/automl_tests/parallel_tests/test_cf_engine.py 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22dd02c...702d987. Read the comment docs.

Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @chukarsten ! Should we file an ice-box issue for figuring out what's causing the test to flake?

@chukarsten
Copy link
Contributor Author

Issue filed @freddyaboulton #2669

@chukarsten chukarsten merged commit 4afe6dd into main Aug 23, 2021
@chukarsten chukarsten mentioned this pull request Sep 1, 2021
@freddyaboulton freddyaboulton deleted the 2582_fix_cf_test branch May 13, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky test_cancel_job for process pool CFEngine
2 participants