-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DropRowsTransformer
#2692
Add DropRowsTransformer
#2692
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2692 +/- ##
=======================================
+ Coverage 99.9% 99.9% +0.1%
=======================================
Files 298 300 +2
Lines 27320 27442 +122
=======================================
+ Hits 27276 27398 +122
Misses 44 44
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, very clean!
evalml/pipelines/components/transformers/preprocessing/drop_rows_transformer.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Left a few comments on potential changes that would be nice, but nothing blocking!
evalml/pipelines/components/transformers/preprocessing/drop_rows_transformer.py
Outdated
Show resolved
Hide resolved
evalml/pipelines/components/transformers/preprocessing/drop_rows_transformer.py
Outdated
Show resolved
Hide resolved
elif is_using_conda: | ||
# No prophet and no arima | ||
n_components = 52 | ||
n_components = 53 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typical codecov 😭
Closes #2682