Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DropRowsTransformer #2692

Merged
merged 7 commits into from
Aug 25, 2021
Merged

Add DropRowsTransformer #2692

merged 7 commits into from
Aug 25, 2021

Conversation

angela97lin
Copy link
Contributor

Closes #2682

@angela97lin angela97lin self-assigned this Aug 24, 2021
@codecov
Copy link

codecov bot commented Aug 24, 2021

Codecov Report

Merging #2692 (a558902) into main (7eccf6e) will increase coverage by 0.1%.
The diff coverage is 97.1%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2692     +/-   ##
=======================================
+ Coverage   99.9%   99.9%   +0.1%     
=======================================
  Files        298     300      +2     
  Lines      27320   27442    +122     
=======================================
+ Hits       27276   27398    +122     
  Misses        44      44             
Impacted Files Coverage Δ
evalml/pipelines/components/__init__.py 100.0% <ø> (ø)
...alml/pipelines/components/transformers/__init__.py 100.0% <ø> (ø)
evalml/tests/component_tests/test_utils.py 95.3% <33.4%> (ø)
.../components/transformers/preprocessing/__init__.py 100.0% <100.0%> (ø)
...ransformers/preprocessing/drop_rows_transformer.py 100.0% <100.0%> (ø)
evalml/tests/component_tests/test_components.py 100.0% <100.0%> (ø)
...ests/component_tests/test_drop_rows_transformer.py 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7eccf6e...a558902. Read the comment docs.

Copy link
Contributor

@eccabay eccabay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, very clean!

Copy link
Contributor

@bchen1116 bchen1116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Left a few comments on potential changes that would be nice, but nothing blocking!

elif is_using_conda:
# No prophet and no arima
n_components = 52
n_components = 53
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typical codecov 😭

@angela97lin angela97lin merged commit 91ffc68 into main Aug 25, 2021
@angela97lin angela97lin deleted the 2682_drop_rows_component branch August 25, 2021 18:13
@chukarsten chukarsten mentioned this pull request Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add component to drop rows
3 participants