-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add label encoder to XGBoost #2701
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2701 +/- ##
=======================================
+ Coverage 99.9% 99.9% +0.1%
=======================================
Files 301 301
Lines 27786 27819 +33
=======================================
+ Hits 27737 27770 +33
Misses 49 49
Continue to review full report at Codecov.
|
@bchen1116 There is currently someone already working on this: #2538 Let's ping them to make sure they're not still working on it. |
@freddyaboulton we hadn't seen much movement, so I gave @bchen1116 the go ahead to rock and roll! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bchen1116 ! Left a couple of questions about decoding but I'm glad we won't be seeing that warning anymore!
fix #2517
Now, we have this in search:
![image](https://user-images.githubusercontent.com/22552445/131029037-b0583ef3-1cba-4f5a-b2f7-086b07f559c5.png)
As opposed to these warnings from before:
![image](https://user-images.githubusercontent.com/22552445/131029211-b8595fc5-b3f1-40b8-afb0-6d02c86172d7.png)
Question: Should I address the remaining warning message (specifying 'error' versus 'logloss' as the default objective for XGBoost, or should a separate issue be filed?