Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add label encoder to XGBoost #2701

Merged
merged 16 commits into from
Sep 2, 2021
Merged

Add label encoder to XGBoost #2701

merged 16 commits into from
Sep 2, 2021

Conversation

bchen1116
Copy link
Contributor

@bchen1116 bchen1116 commented Aug 26, 2021

fix #2517

Now, we have this in search:
image

As opposed to these warnings from before:
image

Question: Should I address the remaining warning message (specifying 'error' versus 'logloss' as the default objective for XGBoost, or should a separate issue be filed?

@bchen1116 bchen1116 self-assigned this Aug 26, 2021
@codecov
Copy link

codecov bot commented Aug 26, 2021

Codecov Report

Merging #2701 (ebaacac) into main (6a1baa9) will increase coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2701     +/-   ##
=======================================
+ Coverage   99.9%   99.9%   +0.1%     
=======================================
  Files        301     301             
  Lines      27786   27819     +33     
=======================================
+ Hits       27737   27770     +33     
  Misses        49      49             
Impacted Files Coverage Δ
...nents/estimators/classifiers/xgboost_classifier.py 100.0% <100.0%> (ø)
...l/tests/component_tests/test_xgboost_classifier.py 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a1baa9...ebaacac. Read the comment docs.

@freddyaboulton
Copy link
Contributor

@bchen1116 There is currently someone already working on this: #2538

Let's ping them to make sure they're not still working on it.

@chukarsten
Copy link
Contributor

@freddyaboulton we hadn't seen much movement, so I gave @bchen1116 the go ahead to rock and roll!

@bchen1116 bchen1116 requested a review from a team August 30, 2021 16:08
Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bchen1116 ! Left a couple of questions about decoding but I'm glad we won't be seeing that warning anymore!

@bchen1116 bchen1116 merged commit 6390473 into main Sep 2, 2021
@chukarsten chukarsten mentioned this pull request Sep 10, 2021
@freddyaboulton freddyaboulton deleted the bc_2517_xgboost_warning branch May 13, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add label encoder to XGBoostClassifier
3 participants