Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ensemble partial dependence bug #2714

Merged
merged 6 commits into from
Aug 31, 2021

Conversation

angela97lin
Copy link
Contributor

Closes #2712

@angela97lin angela97lin self-assigned this Aug 31, 2021
@codecov
Copy link

codecov bot commented Aug 31, 2021

Codecov Report

Merging #2714 (de192a8) into main (6607edf) will decrease coverage by 0.8%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2714     +/-   ##
=======================================
- Coverage   99.9%   99.2%   -0.7%     
=======================================
  Files        301     301             
  Lines      27678   27688     +10     
=======================================
- Hits       27634   27442    -192     
- Misses        44     246    +202     
Impacted Files Coverage Δ
evalml/pipelines/components/utils.py 100.0% <100.0%> (ø)
...del_understanding_tests/test_partial_dependence.py 99.3% <100.0%> (-0.7%) ⬇️
...l/tests/automl_tests/test_pipeline_search_plots.py 25.6% <0.0%> (-74.4%) ⬇️
evalml/automl/pipeline_search_plots.py 46.5% <0.0%> (-53.5%) ⬇️
...ests/automl_tests/test_automl_search_regression.py 84.6% <0.0%> (-15.4%) ⬇️
.../automl_tests/test_automl_search_classification.py 89.5% <0.0%> (-10.5%) ⬇️
evalml/tests/automl_tests/test_automl_utils.py 90.7% <0.0%> (-9.3%) ⬇️
...lml/tests/automl_tests/test_iterative_algorithm.py 95.6% <0.0%> (-4.4%) ⬇️
evalml/automl/utils.py 98.4% <0.0%> (-1.6%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6607edf...de192a8. Read the comment docs.

@@ -140,7 +140,6 @@ def __init__(self, pipeline):
self.pipeline = pipeline
self._estimator_type = "classifier"
if pipeline._is_fitted:
self.feature_importances_ = pipeline.feature_importance
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not used so deleting :0

Copy link
Contributor

@chukarsten chukarsten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Great detective work!

@angela97lin angela97lin merged commit f3c29ed into main Aug 31, 2021
@angela97lin angela97lin deleted the fix_ensemble_partial_dependence_bug branch August 31, 2021 23:34
@chukarsten chukarsten mentioned this pull request Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

partial_dependence with ensembles errors
2 participants