Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set eval_metric for xgboost #2741

Merged
merged 4 commits into from
Sep 7, 2021
Merged

Conversation

freddyaboulton
Copy link
Contributor

Pull Request Description

Fixes #2570

Perf tests here

I didn't see any difference in performance with changing the value of eval_metric so just picking logloss (new default).


After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of docs/source/release_notes.rst to include this pull request by adding :pr:123.

@codecov
Copy link

codecov bot commented Sep 2, 2021

Codecov Report

Merging #2741 (759414a) into main (9c8dd1d) will increase coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2741     +/-   ##
=======================================
+ Coverage   99.9%   99.9%   +0.1%     
=======================================
  Files        301     301             
  Lines      27819   27827      +8     
=======================================
+ Hits       27770   27778      +8     
  Misses        49      49             
Impacted Files Coverage Δ
...nents/estimators/classifiers/xgboost_classifier.py 100.0% <ø> (ø)
evalml/tests/component_tests/test_components.py 100.0% <ø> (ø)
...l/tests/component_tests/test_xgboost_classifier.py 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c8dd1d...759414a. Read the comment docs.

@freddyaboulton freddyaboulton marked this pull request as ready for review September 2, 2021 21:21
@freddyaboulton freddyaboulton changed the title Set evalmetric for xgboost Set eval_metric for xgboost Sep 2, 2021
Copy link
Contributor

@eccabay eccabay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Looking forward to having that warning disappear.

Copy link
Contributor

@bchen1116 bchen1116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@chukarsten chukarsten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for swapping the perf test results in - I thought I was crazy.

@freddyaboulton freddyaboulton merged commit 4abb537 into main Sep 7, 2021
@freddyaboulton freddyaboulton deleted the 2570-set-evalmetric-xgboost branch September 7, 2021 14:46
@chukarsten chukarsten mentioned this pull request Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning from XGBoostClassifier about evaluation metric changing in release 1.3.0
4 participants