-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set eval_metric for xgboost #2741
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2741 +/- ##
=======================================
+ Coverage 99.9% 99.9% +0.1%
=======================================
Files 301 301
Lines 27819 27827 +8
=======================================
+ Hits 27770 27778 +8
Misses 49 49
Continue to review full report at Codecov.
|
eef1ffd
to
f34f6ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Looking forward to having that warning disappear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks for swapping the perf test results in - I thought I was crazy.
Pull Request Description
Fixes #2570
Perf tests here
I didn't see any difference in performance with changing the value of
eval_metric
so just pickinglogloss
(new default).After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of
docs/source/release_notes.rst
to include this pull request by adding :pr:123
.