-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Imputer so that it does not erase ww info during transform #2752
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2752 +/- ##
=======================================
+ Coverage 99.9% 99.9% +0.1%
=======================================
Files 301 301
Lines 27827 27840 +13
=======================================
+ Hits 27778 27791 +13
Misses 49 49
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks Freddy!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for filing and fixing this!
This, along with the few other bugs that have popped up re ww typing, makes me wonder what we could do to make this easier--right now, our components could have potentially different behavior if they weren't fully updated to use ww like the imputer was. No real action, just food for thought 😅
@angela97lin Agreed that it's not comforting to uncover these bugs one-by-one. I will say that the reason that the Imputer did not go through the ww accessor prior to handing the data to the simple imputer is that it didn't need to! The ww type inference used to be almost entirely dependent on the pandas dtype so the simple imputer inference would match the Imputer logical types. Maybe it was always a bug waiting to happen but this implementation got us pretty far. What I'm saying is that as ww inference evolves and matures so will our code because new corner cases that couldn't exist before will begin to exist. I think it could help if we always went through the accessor and never "broke" the schema, i think #2744 can help with that. |
Pull Request Description
Fixes #2751
After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of
docs/source/release_notes.rst
to include this pull request by adding :pr:123
.