Display original feature values in explain predictions #2759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freddyaboulton
changed the title
Codecov Report
@@ Coverage Diff @@
## main #2759 +/- ##
=======================================
+ Coverage 99.8% 99.8% +0.1%
=======================================
Files 301 301
Lines 27850 27897 +47
=======================================
+ Hits 27787 27834 +47
Misses 63 63
Continue to review full report at Codecov.
|
freddyaboulton
force-pushed
the
1359-display-original-feature-values-pred-explanations
branch
from
dcc6412
to
344d34a
Compare
freddyaboulton
requested review from
dsherry,
angela97lin,
bchen1116,
christopherbunn,
chukarsten,
eccabay,
fjlanasa,
jeremyliweishih and
ParthivNaresh
and removed request for
dsherry and
angela97lin
angela97lin
approved these changes
Sep 9, 2021
| for feature_name, feature_value in zip( | ||
| explanation["feature_names"], explanation["feature_values"] | ||
| ): | ||
| if feature_name == "lat": |
There was a problem hiding this comment.
This is just confirming that even if our original value is nan, we don't error, right?
There was a problem hiding this comment.
Right, it'll be displayed in the report like any other feature value!
|
❤️ |
chukarsten
approved these changes
Sep 9, 2021
freddyaboulton
force-pushed
the
1359-display-original-feature-values-pred-explanations
branch
from
344d34a
to
0b52400
Compare
freddyaboulton
deleted the
1359-display-original-feature-values-pred-explanations
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fixes #1359
Users really wanted us to display the original feature value even when there was a standard scaler, so decided to do this in this sprint because it's a small change.
After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of
docs/source/release_notes.rstto include this pull request by adding :pr:123.