Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation for train_data and train_target in prediction explanations #2787

Merged
merged 3 commits into from Sep 16, 2021

Conversation

freddyaboulton
Copy link
Contributor

Pull Request Description

Fixes #2738


After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of docs/source/release_notes.rst to include this pull request by adding :pr:123.

@codecov
Copy link

codecov bot commented Sep 15, 2021

Codecov Report

Merging #2787 (172393c) into main (e93e26f) will increase coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2787     +/-   ##
=======================================
+ Coverage   99.8%   99.8%   +0.1%     
=======================================
  Files        298     298             
  Lines      27631   27646     +15     
=======================================
+ Hits       27563   27578     +15     
  Misses        68      68             
Impacted Files Coverage Δ
...nderstanding/prediction_explanations/explainers.py 100.0% <100.0%> (ø)
...s/prediction_explanations_tests/test_explainers.py 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e93e26f...172393c. Read the comment docs.

@freddyaboulton freddyaboulton marked this pull request as ready for review September 15, 2021 20:34
Copy link
Contributor

@chukarsten chukarsten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a little nit.

mock_ts_pipeline = MagicMock(problem_type=problem_type)

if training_data is not None and training_target is not None:
pytest.xfail("No exception raised in this case")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super nit : extra space

@freddyaboulton freddyaboulton force-pushed the 2738-prediction-explanations-xtrain-ytrain branch from 1a78eb9 to 172393c Compare September 16, 2021 16:00
@freddyaboulton freddyaboulton merged commit d54173a into main Sep 16, 2021
@freddyaboulton freddyaboulton deleted the 2738-prediction-explanations-xtrain-ytrain branch September 16, 2021 16:24
@chukarsten chukarsten mentioned this pull request Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate that training_data and training_target are passed to prediction explanations for time series
2 participants