Add validation for train_data and train_target in prediction explanations#2787
Merged
freddyaboulton merged 3 commits intomainfrom Sep 16, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2787 +/- ##
=======================================
+ Coverage 99.8% 99.8% +0.1%
=======================================
Files 298 298
Lines 27631 27646 +15
=======================================
+ Hits 27563 27578 +15
Misses 68 68
Continue to review full report at Codecov.
|
chukarsten
approved these changes
Sep 16, 2021
Contributor
chukarsten
left a comment
chukarsten
left a comment
There was a problem hiding this comment.
LGTM, just a little nit.
| mock_ts_pipeline = MagicMock(problem_type=problem_type) | ||
|
|
||
| if training_data is not None and training_target is not None: | ||
| pytest.xfail("No exception raised in this case") |
Contributor
There was a problem hiding this comment.
super nit : extra space
freddyaboulton
force-pushed
the
2738-prediction-explanations-xtrain-ytrain
branch
from
1a78eb9 to
172393c
Compare
freddyaboulton
deleted the
2738-prediction-explanations-xtrain-ytrain
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fixes #2738
After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of
docs/source/release_notes.rstto include this pull request by adding :pr:123.