Skip to content

Remove ModelFamily from ComponentBase and Transformers#2828

Merged
bchen1116 merged 4 commits into
mainfrom
bc_2686_modelfamily
Sep 22, 2021
Merged

Remove ModelFamily from ComponentBase and Transformers#2828
bchen1116 merged 4 commits into
mainfrom
bc_2686_modelfamily

Conversation

@bchen1116

Copy link
Copy Markdown
Contributor

fix #2686

@bchen1116 bchen1116 self-assigned this Sep 22, 2021
@codecov

codecov Bot commented Sep 22, 2021

Copy link
Copy Markdown

Codecov Report

Merging #2828 (4e2a8c6) into main (b5410e1) will decrease coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2828     +/-   ##
=======================================
- Coverage   99.8%   99.8%   -0.0%     
=======================================
  Files        297     297             
  Lines      27737   27725     -12     
=======================================
- Hits       27660   27648     -12     
  Misses        77      77             
Impacted Files Coverage Δ
evalml/pipelines/components/component_base.py 100.0% <ø> (ø)
...l/pipelines/components/transformers/transformer.py 100.0% <ø> (ø)
evalml/tests/pipeline_tests/test_pipelines.py 99.8% <ø> (-<0.1%) ⬇️
...valml/pipelines/components/estimators/estimator.py 100.0% <100.0%> (ø)
evalml/tests/component_tests/test_components.py 99.3% <100.0%> (-<0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5410e1...4e2a8c6. Read the comment docs.

@jeremyliweishih jeremyliweishih left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very cool

@freddyaboulton freddyaboulton left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @bchen1116 !!

@bchen1116 bchen1116 merged commit e59a989 into main Sep 22, 2021
@chukarsten chukarsten mentioned this pull request Oct 1, 2021
@freddyaboulton freddyaboulton deleted the bc_2686_modelfamily branch May 13, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove model_family attribute for transformers

3 participants