Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lint to fix jupyter executed cells #2829

Merged
merged 7 commits into from
Sep 23, 2021
Merged

Add lint to fix jupyter executed cells #2829

merged 7 commits into from
Sep 23, 2021

Conversation

bchen1116
Copy link
Contributor

fix #2566

Example usage:
Running 2 different notebooks in different directories:
diff --git adocssourcedemosfraud ipynb bdocssourcedemosfraud ipynb
diff git adocssourceuser_guidedata_actions ipynb bdocssourceuser_data_nsn

lint output

make lint

post lint-fix

Removed the outputs for

The notebooks then become cleaned and are no longer different from the originals

@bchen1116 bchen1116 self-assigned this Sep 22, 2021
@codecov
Copy link

codecov bot commented Sep 22, 2021

Codecov Report

Merging #2829 (6934c70) into main (ab2ed0a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2829   +/-   ##
=====================================
  Coverage   99.8%   99.8%           
=====================================
  Files        297     297           
  Lines      27725   27725           
=====================================
  Hits       27648   27648           
  Misses        77      77           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab2ed0a...6934c70. Read the comment docs.

Copy link
Contributor

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautiful

docs/notebook_version_standardizer.py Outdated Show resolved Hide resolved
Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @bchen1116 ! This will be super useful.

docs/notebook_version_standardizer.py Outdated Show resolved Hide resolved
@bchen1116 bchen1116 merged commit 3cabb2c into main Sep 23, 2021
@chukarsten chukarsten mentioned this pull request Oct 1, 2021
@freddyaboulton freddyaboulton deleted the bc_2566_jupyter branch May 13, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Local dev: update lint tools to check/remove notebook cell output
3 participants