Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests to verify Component Graph support in pipelines #2830

Merged
merged 9 commits into from Sep 23, 2021
Merged

Conversation

bchen1116
Copy link
Contributor

fix #2168

@bchen1116 bchen1116 self-assigned this Sep 22, 2021
@codecov
Copy link

codecov bot commented Sep 22, 2021

Codecov Report

Merging #2830 (8de1663) into main (3cabb2c) will increase coverage by 0.8%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2830     +/-   ##
=======================================
+ Coverage   99.0%   99.8%   +0.8%     
=======================================
  Files        297     297             
  Lines      27725   27741     +16     
=======================================
+ Hits       27434   27664    +230     
+ Misses       291      77    -214     
Impacted Files Coverage Δ
evalml/pipelines/binary_classification_pipeline.py 100.0% <ø> (ø)
...ml/pipelines/multiclass_classification_pipeline.py 100.0% <ø> (ø)
evalml/pipelines/pipeline_base.py 98.3% <ø> (ø)
evalml/pipelines/regression_pipeline.py 100.0% <ø> (ø)
.../pipelines/time_series_classification_pipelines.py 99.0% <ø> (ø)
evalml/pipelines/time_series_pipeline_base.py 99.1% <ø> (ø)
...valml/pipelines/time_series_regression_pipeline.py 100.0% <ø> (ø)
evalml/tests/pipeline_tests/test_pipelines.py 99.8% <100.0%> (+0.1%) ⬆️
evalml/tests/automl_tests/test_automl.py 99.7% <0.0%> (+0.1%) ⬆️
evalml/automl/automl_search.py 99.9% <0.0%> (+0.2%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cabb2c...8de1663. Read the comment docs.

Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @bchen1116 ! Thank you.

evalml/pipelines/pipeline_base.py Show resolved Hide resolved
evalml/tests/pipeline_tests/test_pipelines.py Outdated Show resolved Hide resolved
Copy link
Contributor

@angela97lin angela97lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you! 😁

evalml/tests/pipeline_tests/test_pipelines.py Outdated Show resolved Hide resolved
Copy link
Contributor

@chukarsten chukarsten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@bchen1116 bchen1116 merged commit 20a00c8 into main Sep 23, 2021
@chukarsten chukarsten mentioned this pull request Oct 1, 2021
@freddyaboulton freddyaboulton deleted the bc_2168_cg branch May 13, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pipeline: support ComponentGraph instance as input
4 participants