Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit scikit-learn until errors and new features can be addressed #2842

Merged
merged 2 commits into from
Sep 24, 2021

Conversation

ParthivNaresh
Copy link
Contributor

Fixes: #2841


After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of docs/source/release_notes.rst to include this pull request by adding :pr:123.

@codecov
Copy link

codecov bot commented Sep 24, 2021

Codecov Report

Merging #2842 (84eb587) into main (b01444a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2842   +/-   ##
=====================================
  Coverage   99.8%   99.8%           
=====================================
  Files        302     302           
  Lines      28128   28128           
=====================================
  Hits       28050   28050           
  Misses        78      78           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b01444a...84eb587. Read the comment docs.

Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ParthivNaresh Thank you! This should be good to go once CI passes. Please make the same change to the latest_release_changes branch of the feedstock so that build_conda_pkg passes! No need to submit a PR to the feedstock, you can just push directly to the branch.

https://github.com/conda-forge/evalml-core-feedstock/blob/master/recipe/meta.yaml

@ParthivNaresh ParthivNaresh merged commit 12ea29f into main Sep 24, 2021
@chukarsten chukarsten mentioned this pull request Oct 1, 2021
@freddyaboulton freddyaboulton deleted the Limit-scikitlearn branch May 13, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Limit scikitlearn to 0.24.2 for the time being
2 participants