-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect parameter for baseline regression pipeline in AutoMLSearch #2847
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2847 +/- ##
=======================================
+ Coverage 99.8% 99.8% +0.1%
=======================================
Files 302 302
Lines 28128 28148 +20
=======================================
+ Hits 28050 28070 +20
Misses 78 78
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I had noticed the same issue, but you beat me to it! 😂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great!
@@ -1213,7 +1213,7 @@ def _get_baseline_pipeline(self): | |||
baseline = RegressionPipeline( | |||
component_graph=["Baseline Regressor"], | |||
custom_name="Mean Baseline Regression Pipeline", | |||
parameters={"Baseline Classifier": {"strategy": "mean"}}, | |||
parameters={"Baseline Regressor": {"strategy": "mean"}}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😮
Right now,
_get_baseline_pipeline
sets the parameter for a baseline classifier component in a baseline regression pipeline. This is incorrect!This PR updates this to "Baseline Regressor".