Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect parameter for baseline regression pipeline in AutoMLSearch #2847

Merged
merged 4 commits into from
Sep 28, 2021

Conversation

angela97lin
Copy link
Contributor

Right now, _get_baseline_pipeline sets the parameter for a baseline classifier component in a baseline regression pipeline. This is incorrect!

        elif self.problem_type == ProblemTypes.REGRESSION:
            baseline = RegressionPipeline(
                component_graph=["Baseline Regressor"],
                custom_name="Mean Baseline Regression Pipeline",
                parameters={"Baseline Classifier": {"strategy": "mean"}},
            )

This PR updates this to "Baseline Regressor".

@angela97lin angela97lin self-assigned this Sep 27, 2021
@codecov
Copy link

codecov bot commented Sep 27, 2021

Codecov Report

Merging #2847 (c9345ac) into main (601f43a) will increase coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2847     +/-   ##
=======================================
+ Coverage   99.8%   99.8%   +0.1%     
=======================================
  Files        302     302             
  Lines      28128   28148     +20     
=======================================
+ Hits       28050   28070     +20     
  Misses        78      78             
Impacted Files Coverage Δ
evalml/automl/automl_search.py 99.9% <ø> (ø)
evalml/tests/automl_tests/test_automl.py 99.7% <100.0%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 601f43a...c9345ac. Read the comment docs.

Copy link
Contributor

@eccabay eccabay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I had noticed the same issue, but you beat me to it! 😂

Copy link
Contributor

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@@ -1213,7 +1213,7 @@ def _get_baseline_pipeline(self):
baseline = RegressionPipeline(
component_graph=["Baseline Regressor"],
custom_name="Mean Baseline Regression Pipeline",
parameters={"Baseline Classifier": {"strategy": "mean"}},
parameters={"Baseline Regressor": {"strategy": "mean"}},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😮

@angela97lin angela97lin merged commit cf5aeb7 into main Sep 28, 2021
@angela97lin angela97lin deleted the extraneous_baseline_parameter_regression branch September 28, 2021 00:17
@chukarsten chukarsten mentioned this pull request Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants